Remove PHPStan config file from plugin directory #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixarntz
added
[Type] Enhancement
westonruter
approved these changes
Sep 7, 2023
mukeshpanchal27
approved these changes
Sep 8, 2023
felixarntz
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The wordpress.org plugin build directory currently contains the
phpstan.neon.distfile (see https://plugins.trac.wordpress.org/browser/performance-lab/#trunk) which shouldn't be part of it. This was likely an oversight from #730 where PHPStan was added. This PR addresses it by adding the file to.gitattributesso that it is ignored starting with the next release.Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.