Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub format Co-Authored-By for unlinked contributors #28

Closed
desrosj opened this issue Jan 23, 2024 · 1 comment
Closed

Use GitHub format Co-Authored-By for unlinked contributors #28

desrosj opened this issue Jan 23, 2024 · 1 comment
Labels
wontfix This will not be worked on

Comments

@desrosj
Copy link
Contributor

desrosj commented Jan 23, 2024

Using GitHub flavored Co-Authored-By trailers with ID+username format emails will:

  • Still allow parsing and conversion to w.org accounts.
  • Still allows contributors to connect w.org accounts after a contribution is merged and receive credit.
  • Gives contributors credit on GH for their contribution. With the current Unlinked contributors: x, y, z. format, they will never receive attribution on GH (only .org after their account is connected and the props script is run).
@desrosj
Copy link
Contributor Author

desrosj commented Jan 31, 2024

After talking this over with several contributors and getting some input from @josephahaden, I've decided not to make this change.

Including attribution with a GitHub formatted email removes some of the incentive and motivation for a contributor to establish a connection between w.org and GH accounts.

However, I've decided to leave the Unlinked: x, y, z. format in place. It's reasonable to track the contribution in a way that allows us to attribute it to a contributor should they make a connection in the future.

@desrosj desrosj closed this as completed Jan 31, 2024
@desrosj desrosj added the wontfix This will not be worked on label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant