Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from title casing to sentence casing #39

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

desrosj
Copy link
Contributor

@desrosj desrosj commented Feb 1, 2024

What?

This changes the casing for the co-authored trailer from sentence to title casing.

Why?

In #28, the casing for Co-authored-by was changed from sentence to title. At the time it was done to see if the casing was the reason why the trailers were not being picked up. It turned out there were other issues causing this.

After some more research, it seems that most tools use sentence casing for the trailer rather than title casing, including suggestions for the trailer in the GitHub suggested merge commit message. This changes the casing used for consistency.

@desrosj desrosj self-assigned this Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: desrosj.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj desrosj merged commit 2f7af07 into trunk Feb 1, 2024
4 checks passed
@desrosj desrosj deleted the change/casing-of-trailer branch February 1, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant