Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some debug data is not being logged correctly #72

Open
desrosj opened this issue Feb 16, 2024 · 1 comment
Open

Some debug data is not being logged correctly #72

desrosj opened this issue Feb 16, 2024 · 1 comment
Assignees
Labels
Good First Issue Good for newcomers [Type] Bug Report Something isn't working

Comments

@desrosj
Copy link
Contributor

desrosj commented Feb 16, 2024

Description

When running the bot in debug mode, some of the data logged is empty even though there are valid values (we know because the bot works).

Version

v1

Workflow file

No response

Link

https://github.com/WordPress/props-bot-action/actions/runs/7923792615/job/21634347897#step:3:25

@desrosj desrosj added the [Type] Bug Report Something isn't working label Feb 16, 2024
@desrosj desrosj self-assigned this Feb 16, 2024
@aaronjorbin
Copy link
Member

I think this is due to debug requiring a string. https://github.com/actions/toolkit/blob/master/packages/core/src/core.ts#L129

Might be worth having our own wrapper that calls JSON.stringify on non strings

@desrosj desrosj added the Good First Issue Good for newcomers label Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers [Type] Bug Report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants