Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for adding contributors via a comment #87

Open
jrfnl opened this issue Mar 8, 2024 · 2 comments
Open

Allow for adding contributors via a comment #87

jrfnl opened this issue Mar 8, 2024 · 2 comments
Assignees
Labels
[Type] Feature Request New feature or request

Comments

@jrfnl
Copy link
Member

jrfnl commented Mar 8, 2024

Problem

At times, there may be contributors to a PR who haven't left a comment on the ticket/PR.

Example:

  • People with whom the PR was discussed in person, in a video-call or on Slack

I think it would be good if these could be added to the props list in a transparent and straight-forward manner.

Feature Request

I can think of a couple of possible solutions:

  1. Being able to leave a comment on a PR in the "Unlinked contributors: nacin, matt." format.
    Adding the "props-bot" label after leaving the comment should updated the props list and include the contributors mentioned in the "Unlinked contributors" comment.
  2. Have a specific command which does both in one go. Something like @props-bot add nacin, matt, which would trigger the props-bot to update the props list with the mentioned names.

This feature would be susceptible to "props spam", i.e people triggering the bot to add people who have not contributed to the feature, but then again, this whole system is susceptible to "props spam" anyway as I regularly see people leaving a comment on PRs without any noteworthy input only to get props.

Workaround

No response

Repository

https://github.com/WordPress/wordpress-develop

@jrfnl jrfnl added the [Type] Feature Request New feature or request label Mar 8, 2024
@desrosj
Copy link
Contributor

desrosj commented Mar 14, 2024

This seems like a duplicate of #22, and related to #48.

This feature would be susceptible to "props spam", i.e people triggering the bot to add people who have not contributed to the feature, but then again, this whole system is susceptible to "props spam" anyway as I regularly see people leaving a comment on PRs without any noteworthy input only to get props.

Unfortunately, I don't think we can ever fully account for this without a manual review step in this process. It's long been the practice for SVN to perform a manual review while collecting props, and it's recommended and documented in the new processes for Git.

@jrfnl
Copy link
Member Author

jrfnl commented Mar 14, 2024

@desrosj Feel free to close as duplicate if you think the earlier issue is descriptive enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants