Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow directly copying the db.php file #30

Merged
merged 2 commits into from
Apr 30, 2023
Merged

Allow directly copying the db.php file #30

merged 2 commits into from
Apr 30, 2023

Conversation

aristath
Copy link
Member

See details in #29

@aristath aristath requested a review from adamziel March 31, 2023 08:49
@aristath aristath linked an issue Mar 31, 2023 that may be closed by this pull request
Don't use {SQLITE_IMPLEMENTATION_FOLDER_PATH} #29
Closed
@aristath
Copy link
Member Author

Hmmm actually this won't work... WP_PLUGIN_DIR is not defined when db.php gets loaded in Core 🤔

@adamziel
Copy link
Collaborator

adamziel commented Apr 14, 2023 •
edited
Loading

@aristath yes, I just ran into that the other day. Perhaps we could use realpath(__DIR__ . '/../wp-content/plugins') or something to that effect instead?

@aristath
Copy link
Member Author

aristath commented Apr 18, 2023 •
edited
Loading

@adamziel I just pushed an update if you want to try this 👍

@adamziel
Copy link
Collaborator

Added to my list 👍

adamziel
adamziel approved these changes Apr 29, 2023
View reviewed changes
Copy link
Collaborator

@adamziel adamziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome and worked for me, thank you @aristath !

@adamziel adamziel merged commit fdc1417 into main Apr 30, 2023
@adamziel adamziel deleted the try/29 branch April 30, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamziel adamziel adamziel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't use {SQLITE_IMPLEMENTATION_FOLDER_PATH}
2 participants
@aristath @adamziel