Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

Fix RTL alignments #425

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Fix RTL alignments #425

merged 1 commit into from
Oct 31, 2018

Conversation

jasmussen
Copy link
Collaborator

This fixes #325.

It should be paired with WordPress/gutenberg#11293.

This PR adds RTL ignore comments to the block alignment classes so the values are not overridden.

Before:

screenshot 2018-10-31 at 12 04 04

After:

screenshot 2018-10-31 at 12 04 10

This fixes #325.

It should be paired with WordPress/gutenberg#11293.

This PR adds RTL ignore comments to the block alignment classes so the values are not overridden.
@jasmussen jasmussen added the bug Something isn't working label Oct 31, 2018
@jasmussen jasmussen added this to the RC1 milestone Oct 31, 2018
@jasmussen jasmussen self-assigned this Oct 31, 2018
Copy link
Collaborator

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

LTR:
screen shot 2018-10-31 at 8 43 49 am

RTL:
screen shot 2018-10-31 at 8 44 47 am

@kjellr kjellr merged commit fa19a1f into master Oct 31, 2018
@kjellr kjellr deleted the fix/rtl-alignments branch October 31, 2018 12:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alignleft and alignright are switched on RTL
2 participants