Fix RTL block alignments #11293
Merged
Fix RTL block alignments #11293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you explicitly pick an alignment in the editor, this alignment should be respected regardless of text direction. "Align left" is always _align left_. This PR fixes that by adding ignore comments to the auto RTL prefixer
jasmussen
pushed a commit
to WordPress/twentynineteen
that referenced
this pull request
Oct 31, 2018
This fixes #325. It should be paired with WordPress/gutenberg#11293. This PR adds RTL ignore comments to the block alignment classes so the values are not overridden.
jasmussen
force-pushed
the
fix/rtl-alignments
branch
from
506348c
to
dcdad03
Compare
|
Pushed an additional fix that addresses an issue with block toolbars. Before:
After:
|
gziolo
added
the
Internationalization (i18n)
|
Note that the frontend will only look right once the upstream gutenberg PR is merged. |
|
Oh sorry I wrote that comment on the wrong repo 😅 |
daniloercoli
added a commit
that referenced
this pull request
Nov 1, 2018
…rnmobile/port-quote-block-step-1 * 'master' of https://github.com/WordPress/gutenberg: (22 commits) Add removed periods to block descriptions. (#11367) Remove findDOMNode usage from the inserter (#11363) Remove deprecated componentWillReceiveProps from TinyMCE component (#11368) Create file blocks when dropping multiple files at once (#11297) Try avoiding the deprecated findDOMNode API from DropZone Provider (#11168) Fix: make meta+A behaviour of selecting all blocks work on safari and firefox. (#8180) Remove _wpGutenbergCodeEditorSettings and wp.codeEditor assets (#11342) Remove the Cloudflare warning (#11350) Image Block: Use source_url for media file link (#11254) Enhance styling of nextpage block using the Hr element (#11354) Embed block refactor and tidy (#10958) Nonce Middleware: Wrap the nonce middleware function into it's own function that isn't regenerated on every API request. (#11347) Fix RTL block alignments (#11293) RichText: fix buggy enter/delete behaviour (#11287) Remove code coverage setup (#11198) Parser: Runs all parser implementations against the same tests (#11320) Stop trying to autosave when title and classic block content both are empty. (#10404) Fix "Mac OS" typo + use fancy quotes consistently (#11310) Update documentation link paths (#11324) Editor: Reshape blocks state under own key (#11315) ... # Conflicts: # gutenberg-mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you explicitly pick an alignment in the editor, this alignment should be respected regardless of text direction.
"Align left" is always align left. This PR fixes that by adding ignore comments to the auto RTL prefixer.
Steps to reproduce:
Before:
After: