This repository has been archived by the owner on Jan 15, 2019. It is now read-only.
Simplify nav submenu markup and improve no-JS behavior #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
3 tasks
allancole
reviewed
Nov 5, 2018
There was a problem hiding this comment.
Thanks for all the continued work on this menu Weston! I ended up merging the changes in this PR into #485 which includes some additional fixes for accessibility and non-click interactions. Since the code is already in there and working, we may end up closing this PR in favor of the other.
|
Yes, I saw that you merged my commits over there. So that's great. |
|
Closing this since it’s merged into #485 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #337.
onclickattribute.👉 These changes improve the nav menu experience when JavaScript is turned off in the browser.