Replace Genericons with SVG icons. #253

samikeijonen · 2016-10-11T17:15:25Z

Clean PR for replacing Genericons with SVG icons.

typo in style.css for h1 size

Swapping tagline color from #bbb to white (the site title color), and using opacity to make it lighter.

…e/tagline-color

Actually includng the change in the PR

The offset includes the navigation height, so it wasn’t docking until the menu went offscreen. By subtracting the menu height when there’s a custom image, we dock the menu at the right scroll position.

Appears to be functionally duplicate to `site-navigation-fixed`, and is causing a “sticky menu” bug.

melchoyce · 2016-10-11T17:54:19Z

Looks like there's a Travis check failing, @samikeijonen.

samikeijonen · 2016-10-11T18:15:16Z

Yes, I asked @grappler how to solve that. I don't know how that works 😏

josephfusco · 2016-10-11T18:32:08Z

@samikeijonen If you don't have this installed in your text editor I recommend you do.

https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards#how-to-use

That contains some info on setting up in a few different editors, but if you use Atom here is an awesome post on that specifically. https://tommcfarlin.com/using-php-codesniffer/

Takes some time setting up but allows you to see all of these inline with your code before they reach travis.

samikeijonen · 2016-10-11T18:41:06Z

Thanks @josephfusco. I have tried Atom but had some weird issues on Windows. Going to check again.

2. Remove twentyseventeen_do_svg() function.

…l displayed size, not only full viewport width. Handles both content images and featured images. Reworked from Twenty Sixteen.

Remove the animation when “docking” the menu after scroll for a smoother experience.

samikeijonen · 2016-10-13T05:56:29Z

Thanks @laurelfulford for review!

I might have not enough time or skills to fix all the issues (IE8 support, adding icons for comment author and blockquote, minor styling issues) before this is merged to Core. I already talked about this with @davidakennedy.

Therefore I suggest that we do final decision about using SVGs or not. If yes, I suggest that we merge this PR. It's helpful on several ways.

Other people can more easily jump in and fix SVG related issues.
Avoid double work if there are fixes in Genericon styles in the same time.

samikeijonen · 2016-10-13T06:00:20Z

@ryelle suggestion seems best for using blockquote icon.

For comment author icon I wish there was is_post_author() function. We could then put SVG icon directly in the markup without JS. I'll check how is_post_author() function could work.

…ssue When a navigation menu has too many menu items in it, unstick it.

Adding twentyseventeen_entry_footer() to content-*.php

Add custom sizes attributes to responsive images

…ost-format is set to gallery AND post has a gallery)

…ost-format is set to video AND post has a video)

Hide featured image on blog/archive, if post has gallery or video

Fixes alignment of nav and page content

2. Remove twentyseventeen_do_svg() function.

behance deviantart medium slideshare snapchat vine vk yelp Not added Goodreads

…ments pagination.

samikeijonen · 2016-10-14T07:47:49Z

Okay, I messed this PR also. It ain't funny anymore 😄. Everything should be OK but there are other commits seen also in this PR.

Now I need your help how to proceed.

Create another clean PR.
Merge this if possible.
We can always go with Genericons. There have been new commits to that direction also.

imnok and others added 20 commits September 25, 2016 00:32

Update style.css for Thai Font. Issue WordPress#59

47e6964

Update style.css for Thai Font. Issue WordPress#59

dba9d65

Resolves too many menu items issue and closes WordPress#150

dd653bf

Second solution for nav is too big issue, closes WordPress#150

b8bc263

removed unnecessary space

978d6cf

Removes fixed nav at one third window height

0410b9f

h1 heading from em to rem

07b0dca

typo in style.css for h1 size

Merge branch 'WordPress/master' into my-2017

7116b1c

Remove the animation when “docking” the menu

b402fa8

Swap tagline color for opacity

3c6c2c8

Swapping tagline color from #bbb to white (the site title color), and using opacity to make it lighter.

Swapping spaces for tabs

f2121f0

Swap tagline color for opacity

951386b

Swapping tagline color from #bbb to white (the site title color), and using opacity to make it lighter.

Swapping spaces for tabs

2a576d3

Merge remote-tracking branch 'origin/update/tagline-color' into updat…

2d86ec3

…e/tagline-color

New style for abbr

fbae3bc

Actually includng the change in the PR

Fix incorrect offset for front page with a custom header

b328f73

The offset includes the navigation height, so it wasn’t docking until the menu went offscreen. By subtracting the menu height when there’s a custom image, we dock the menu at the right scroll position.

Remove the site-navigation-hidden class & js trigger

2b5fdcd

Appears to be functionally duplicate to `site-navigation-fixed`, and is causing a “sticky menu” bug.

Calculate outerHeight to include the 1-pixel border

92a18a1

Merge branch 'master' into new_abbr_again

b1409e1

Replace Genericons with SVG icons.

3b76833

samikeijonen mentioned this pull request Oct 11, 2016

Replace Genericons with SVG icons #206

Closed

Remove unnecessary $args.

508bff6

samikeijonen and others added 4 commits October 11, 2016 23:21

Trying to fix some of the Travis errors.

d3978d8

1. Use require_once() for loading icons.

89ab3a0

2. Remove twentyseventeen_do_svg() function.

Adds control of sizes attribute in responsive images to reflect actua…

98d1b5a

…l displayed size, not only full viewport width. Handles both content images and featured images. Reworked from Twenty Sixteen.

Merge pull request WordPress#151 from ryelle/menu-animation

6a2de1f

Remove the animation when “docking” the menu after scroll for a smoother experience.

josh and others added 15 commits October 12, 2016 23:01

fixes window resize bug

a2caa7b

removes console.log and closes WordPress#150

909b654

Fixes alignment of nav and page content, closes WordPress#165

b44f657

adding twentyseventeen_entry_footer() to content-*.php

983affe

removing twentyseventeen_entry_footer() from content-excerpt.php

3a0e206

Merge pull request WordPress#168 from joshcummingsdesign/menu-items-i…

2666a6b

…ssue When a navigation menu has too many menu items in it, unstick it.

Merge pull request WordPress#261 from enodekciw/post-format-meta

cc5c5c6

Adding twentyseventeen_entry_footer() to content-*.php

Merge pull request WordPress#254 from mor10/responsive-featured-images

1202b24

Add custom sizes attributes to responsive images

Update CONTRIBUTORS.md

3e1e7cf

Remove escaping from translated strings.

b1271f3

do not display featured image on the blog/archive index pages (when p…

babefb3

…ost-format is set to gallery AND post has a gallery)

do not display featured image on the blog/archive index pages (when p…

92ea5a7

…ost-format is set to video AND post has a video)

fixes travis-ci build

eafabb7

Merge pull request WordPress#300 from enodekciw/formats-featured-images

0ab07d0

Hide featured image on blog/archive, if post has gallery or video

Merge pull request WordPress#284 from joshcummingsdesign/nav-margins

4f3531f

Fixes alignment of nav and page content

samikeijonen mentioned this pull request Oct 14, 2016

Pull request template #276

Merged

samikeijonen added 8 commits October 14, 2016 09:39

Replace Genericons with SVG icons.

3492881

Remove unnecessary $args.

bbe44a7

Trying to fix some of the Travis errors.

80bb606

1. Use require_once() for loading icons.

a5a3949

2. Remove twentyseventeen_do_svg() function.

Add new social icons:

d1ba073

behance deviantart medium slideshare snapchat vine vk yelp Not added Goodreads

Add the_comments_pagination() function and replace similar custom com…

ae3a8f3

…ments pagination.

Remove escaping from translated strings.

cdc8026

Try to fix merge conflicts.

47c59cb

davidakennedy merged commit 47c59cb into WordPress:master Oct 14, 2016

laurelfulford mentioned this pull request Oct 15, 2016

RTL fixes needed for SVG update #344

Closed

gregrickaby mentioned this pull request Oct 21, 2016

Bring back over Aria/a11y tweaks used in TwentySeventeen's SVG workflow WebDevStudios/wd_s#207

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace Genericons with SVG icons. #253

Replace Genericons with SVG icons. #253

samikeijonen commented Oct 11, 2016

melchoyce commented Oct 11, 2016

samikeijonen commented Oct 11, 2016

josephfusco commented Oct 11, 2016 •

edited

samikeijonen commented Oct 11, 2016

samikeijonen commented Oct 13, 2016

samikeijonen commented Oct 13, 2016

samikeijonen commented Oct 14, 2016 •

edited

Replace Genericons with SVG icons. #253

Replace Genericons with SVG icons. #253

Conversation

samikeijonen commented Oct 11, 2016

melchoyce commented Oct 11, 2016

samikeijonen commented Oct 11, 2016

josephfusco commented Oct 11, 2016 • edited

samikeijonen commented Oct 11, 2016

samikeijonen commented Oct 13, 2016

samikeijonen commented Oct 13, 2016

samikeijonen commented Oct 14, 2016 • edited

josephfusco commented Oct 11, 2016 •

edited

samikeijonen commented Oct 14, 2016 •

edited