This repository has been archived by the owner on Jan 10, 2018. It is now read-only.
Update sticky icon to appear on all post formats, only on blog index #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed on the blog index, when the post is sticking.
|
Looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sticky icon was only appearing on post formats using the content.php file - so it was not appearing on sticky audio, video, gallery or image posts:
When it was displaying, it was also appearing on single posts, and whenever the post appeared, not just in its stuck position. Here's an example of the sticky post:
This PR makes sure the icon only appears on the blog index, when the post is 'stuck' (and not in the regular flow), and for all post formats.