Rename widget areas to "sidebar-1" and "sidebar-2"

[ocean90]

twentytwenty/functions.php

Lines 331 to 353 in bbfc370

	// Footer #1.
	register_sidebar(
	array_merge(
	$shared_args,
	array(
	'name' => __( 'Footer #1', 'twentytwenty' ),
	'id' => 'footer-one',
	'description' => __( 'Widgets in this area will be displayed in the first column in the footer.', 'twentytwenty' ),
	)
	)
	);
	// Footer #2.
	register_sidebar(
	array_merge(
	$shared_args,
	array(
	'name' => __( 'Footer #2', 'twentytwenty' ),
	'id' => 'footer-two',
	'description' => __( 'Widgets in this area will be displayed in the second column in the footer.', 'twentytwenty' ),
	)
	)
	);

When switching themes, WordPress tries to map previous widget areas to the new theme, see wp_map_sidebars_widgets(). Unfortunately, the current naming ("footer-one" and "footer-two") are preventing this.

[joyously]

We discussed this before. There is a mapping for "footer", so that should work. I don't think it should be named sidebar if it's not on the side.

[pattonwebz]

In testing this there are quite a lot of themes that contain footer-one but there are a lot more themes that have sidebar-1 as their names.

Personally I feel like the semantics of labelling as the footer areas could be handled by the labels - with names mapped to whatever is deemed most appropriate.

[pattonwebz]

OK so after looking at this and doing various searches on the existing directory I found that the best option is to swap the ids of the menus to be sidebar-1 and sidebar-2.

This is based mostly on the numbers of themes that utilise these exact names. Firstly for core themes there are several million installs where they sync but this pair is also the most common in non-core themes as well.

Some general match numbers on basic searches:

('|")(sidebar-1|sidebar-2)('|")
('|")(footer-one|footer-two)('|")