Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Meet WCAG AA level accessibility requirements #3

Closed
luminuu opened this issue Aug 24, 2023 · 9 comments
Closed

Meet WCAG AA level accessibility requirements #3

luminuu opened this issue Aug 24, 2023 · 9 comments

Comments

@luminuu
Copy link
Member

luminuu commented Aug 24, 2023

2024 should be WCAG AA level compliant. What is needed to achieve this? Let's use this issue to discuss and track.

Some resources:

For reference, here's the same discussion for Twenty Twenty-Two: WordPress/twentytwentytwo#82

@carolinan
Copy link
Contributor

carolinan commented Sep 29, 2023

Result of the accessibility-ready review

Requirements

Keyboard Navigation -pass, (Besides known issues reported for the navigation block in the Gutenberg GitHub repository)
Controls -pass
Skip Links -pass except for the portfolio home template
Forms -pass.

Headings
H1 is missing on the default home template
H1 is missing on the writer home template
H1 is missing from the portfolio home template

The content of the portfolio page pattern is difficult to read because it has no headings. (This is the portfolio pattern that shows up when you create a new single page)

ARIA Landmark Roles
The sidebar should have its own landmark (aside)
Single with sidebar: the main is in the wrong place, it does not wrap the featured image, title or post meta.
Main is missing from the portfolio home template

Content Links
Some links in the sidebar does not change visually when you :hover over them
(Perhaps the underline could be removed on hover).

Repetitive Link Text -pass

Contrasts
Needs more careful testing
Milky: The default link color has too low contrast against the background

Not tested yet:
Images
Media
Screen Reader Text
Not Allowed

@kafleg
Copy link
Member

kafleg commented Oct 2, 2023

Contrast

Onyx Style - Very low contrast between text and background colors found in the home page testimonial section.

@carolinan
Copy link
Contributor

carolinan commented Oct 3, 2023

Continued:

Images -Pass. For the lightbox PR to be merged, the lightbox accessibility issues in core/Gutenberg must first be fixed.
Media -pass
Screen Reader Text -pass
Not Allowed -pass

@carolinan
Copy link
Contributor

If the linked post date block is replaced with a "read more", the "repetitive link text" requirement needs to be considered and a new review should be done.

luminuu added a commit that referenced this issue Oct 4, 2023
…ility-requirements

#3 meet wcag aa level accessibility requirements
@kafleg
Copy link
Member

kafleg commented Oct 11, 2023

Contrast error found in Milky style.
image

@kafleg
Copy link
Member

kafleg commented Oct 11, 2023

H1 missing on the About page pattern.

image

@luminuu
Copy link
Member Author

luminuu commented Oct 11, 2023

@kafleg Milky has been renamed to Fossil, are you checking on the latest version of trunk? The colors have been updated and are not causing contrast issues anymore.

@kafleg
Copy link
Member

kafleg commented Oct 11, 2023

You are right. I was checking theme that is bundled in Beta 3.

Now, checking trunk version.

@kafleg
Copy link
Member

kafleg commented Oct 11, 2023

Onyx Style - Found 1 1 Contrast Errors. 1 X Very low contrast

It is appearing here, It is blog home template.
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants