Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

#3 meet wcag aa level accessibility requirements #564

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Oct 4, 2023

Description

  • Single with sidebar: Fix the main tag wrong place, it did not wrap the featured image, title or post meta.
  • Fix missing main tag from the portfolio home template
    (Fixes ARIA landmark roles)

Screenshots

Testing Instructions

Single with sidebar

  • Edit a post
  • Change template to Single with sidebar
  • Save and view the page
  • Inspect page to check the content of the post is in main tags.

Home protfolio

  • Go to Appearance->Editor->Templates->Blog Home
  • Edit template, click on the 3 dots in the top right corner.
  • Click on Code Editor
  • Select all the content and delete
  • Save and exit the edit of Blog Home
  • Edit Blog Home again and a modal with patterns will appear.
  • Select the Home portfolio pattern ( The name would not be visible, you have to remember the way it looks)
  • Save and exit editor.
  • Visit Home page and check the pattern is there.
  • Inspect the page and check main tag is there and contains the content.

Contributors

[vraja-pro]

Copy link
Member

@luminuu luminuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and both work as expected.

@luminuu luminuu merged commit fe6421b into WordPress:trunk Oct 4, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants