-
Notifications
You must be signed in to change notification settings - Fork 90
Conversation
Hi @Riyadh1734 - I don't think this is good idea to add into the theme, in particular using mention of the pandemic quarantine. I understand the intention of your submission, but this has the potential to bring back some painful memories/experiences for some folks, and I think the "This page could not be found." is sufficient. |
@@ -9,7 +9,7 @@ <h2 class="has-text-align-center" style="font-size:clamp(4rem, 40vw, 20rem);font | |||
<!-- wp:paragraph {"align":"center"} --> | |||
<p class="has-text-align-center">This page could not be found.</p> | |||
<!-- /wp:paragraph --> | |||
|
|||
<div class="msg">Maybe this page moved? Got deleted? Is hiding out in quarantine? Never existed in the first place?<p>Let's go <a href="#">home</a> and try from there.</p></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div class="msg">Maybe this page moved? Got deleted? Is hiding out in quarantine? Never existed in the first place?<p>Let's go <a href="#">home</a> and try from there.</p></div> | |
<div class="msg"> | |
<p>Maybe this page moved, got deleted or never existed in the first place?</p> | |
<p>Let's go <a href="/">home</a> and try from there.</p> | |
</div> |
I think this should be done more like this - with 2 paragraphs and a real link to home.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be changed anytime. Thank you for your suggestion.
I think, if anything it could be more aligned with prior default themes;
There is no need imo for a home link as headers typically have that. |
Thanks for the discussion everyone. I agree with @jeffikus on this one. If you'd like to update the default message to be:
That works for me. 👍 As it is currently, the markup in this PR is not valid block markup though. We'd want to just replace the string on L10. |
There is no problem that the home link can be omitted. But there are two lines very important for new users. |
Hi @jeffikus I agree with you about mentioning pandemic quotes but another two lines are very important for new users & it seems too different but it's helpful. |
@Riyadh1734 I hear what you are trying to achieve, my counter point would be then do we list all the possible reasons why a page could not be found? From my perspective that's what the search field is for, the only addition I would consider here is the second part of this line, the "Maybe try a search?" part. |
Just chiming in here to say I am indifferent to the actual message used. My concerns were only to not mention quarantine and that the text is contained within the right (semantically) markup. |
@jeffikus lf this is good for all folks.then that's also ok for me. Go for it :) |
Improving a little bit changes to the 404 error page. I think this is most important to users.