This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Replace template strings with translatable patterns #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Saju Ahmed <59993047+Riyadh1734@users.noreply.github.com>
jffng
commented
Oct 29, 2021
inc/patterns/general-404.php
Outdated
| <h2 class="has-text-align-center" style="font-size:clamp(4rem, 40vw, 20rem);font-weight:200;line-height:1;margin-top:0;margin-bottom:0;">404</h2> | ||
| <!-- /wp:heading --> | ||
| <!-- wp:paragraph {"align":"center"} --> | ||
| <p class="has-text-align-center">' . esc_html( 'This page could not be found. Maybe try a search?', 'twentytwentytwo' ) . '</p> |
There was a problem hiding this comment.
Implemented the suggestion from here #154 (comment)
jffng
commented
Oct 29, 2021
|
@jffng rather than implement a separate credit line block, can we just make the entirety of the https://github.com/WordPress/twentytwentytwo/blob/trunk/inc/patterns/footer-default.php |
|
I just tried that and it causes a layout issue because of the additional wrapping div introduced by the pattern block:
|
|
I have an idea for a fix in Gutenberg which would remove this wrapping div entirely. |
Cool — ideally these should be entirely seamless replacements. |
7 tasks
kjellr
reviewed
Oct 29, 2021
|
Assuming WordPress/gutenberg#36090 lands, this PR seems to be in good shape. 👍 |
Co-authored-by: Kjell Reigstad <kjell.reigstad@automattic.com>
|
Merging since the above Gutenberg PR landed. |
Closed
jeffpaul
added a commit
to jeffpaul/twentytwentytwo
that referenced
this pull request
Nov 16, 2021
Note that some of the references below are not the only contributions (commits, PR review, helpful issue input, etc.) from these folks, but merely the first ones I encountered while reviewing items committed to `trunk` since the initial branch commit. @westonruter via WordPress#51 @ntwb via WordPress#73 @juricav via WordPress#113 @Sandstromer via WordPress#69 @jasmussen via WordPress#74 @melchoyce via WordPress#16 @Riyadh1734 via WordPress#182 @desrosj via WordPress#223 @beafialho via WordPress#172 @clucasrowlands via WordPress#171 @Otto42 via WordPress#28 @luminuu via WordPress#107 @felixarntz via WordPress#240
kjellr
added a commit
that referenced
this pull request
Nov 17, 2021
* add missing props to CONTRIBUTORS.md Note that some of the references below are not the only contributions (commits, PR review, helpful issue input, etc.) from these folks, but merely the first ones I encountered while reviewing items committed to `trunk` since the initial branch commit. @westonruter via #51 @ntwb via #73 @juricav via #113 @Sandstromer via #69 @jasmussen via #74 @melchoyce via #16 @Riyadh1734 via #182 @desrosj via #223 @beafialho via #172 @clucasrowlands via #171 @Otto42 via #28 @luminuu via #107 @felixarntz via #240 * add dotorg handles to CONTRIBUTORS.md * Fix Rich's WP.org username. Co-authored-by: Kjell Reigstad <kjell@kjellr.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a 404 pattern to the general category, and implements it patterns inside the 404 template. It also replaces the contents of
footer.htmlwith thefooter-defaultpattern.This is done so that the strings can be marked for translation.
Closes #30.
Screenshots
There should be no visual change.
Testing Instructions
Go to a 404 page and verify the contents appear as expected.