Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker env config for Events network #910

Closed
5 of 6 tasks
iandunn opened this issue Jun 19, 2023 · 4 comments
Closed
5 of 6 tasks

Update Docker env config for Events network #910

iandunn opened this issue Jun 19, 2023 · 4 comments
Assignees

Comments

@iandunn
Copy link
Member

iandunn commented Jun 19, 2023

#907 added some basic config for the Docker env, but more is needed to fully support and provision the new Events network.

  • Basic wp-config.php updates
  • Basic nginx.conf updates
  • Add nginx rule for /xmlrpc.php, something like rewrite "/[\w-]+/\d{4}/[\w-]+/xmlrpc\.php" /xmlrpc.php last;
  • Add nginx rule for uploaded files, something like rewrite "/[\w-]+/\d{4}/[\w-]+/files/(.+)$" /wp-includes/ms-files.php?file=$1 last;
  • Create new root site and example event sites. Update EVENTS_ROOT_BLOG_ID if it doesn't already match.
  • Comprehensive testing

Other changes may be needed as well.

@iandunn
Copy link
Member Author

iandunn commented Jun 20, 2023

I merged #912, which added the parts that I needed to do in order to work on #907. More changes and testing will be needed to make this issue complete, though.

@iandunn
Copy link
Member Author

iandunn commented Jun 29, 2023

I moved the task for updating the database to #668, because that's related and it's messy to try and have competing diffs for the SQL export

@timiwahalahti
Copy link
Collaborator

I tested the Events network, and it seems to work as expected. I will leave this open, in case someone else wants to do more testing.

@StevenDufresne
Copy link
Contributor

I'll close this for now, it has been working for me and @timiwahalahti also gave it a test.

We can reopen if we come up with a clearer definition of "Comprehensive testing", otherwise things could just be logged as bugs in the issue tracker as normal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants