Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Pilot Events network and URL support #907

Merged
merged 9 commits into from Jun 21, 2023
Merged

Conversation

iandunn
Copy link
Member

@iandunn iandunn commented Jun 16, 2023

See #884
See #885

This handles the interdependent parts of those issues, which covers everything needed to create sites like events.wordpress.test/barcelona/2023/diversity-day/, and have requests routed appropriately.

Testing

⚠️ Do this in a local environment, since more testing is needed before we test this on a w.org sandbox

@iandunn iandunn added this to the Pilot Events: MVP milestone Jun 16, 2023
@iandunn iandunn self-assigned this Jun 16, 2023
@iandunn iandunn force-pushed the events-network branch 3 times, most recently from 85ee9ce to 2985c5d Compare June 21, 2023 00:50
@iandunn iandunn marked this pull request as ready for review June 21, 2023 00:52
@iandunn iandunn requested review from dd32 and pkevan June 21, 2023 00:53
Copy link
Member

@dd32 dd32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than some nitpicks around what field is used for switching between the two, this seems good to me (Untested) and I don't really understand the hesitation of just committing and iterating from there.

public_html/wp-content/sunrise.php Outdated Show resolved Hide resolved
public_html/wp-content/mu-plugins/latest-site-hints.php Outdated Show resolved Hide resolved
@pkevan
Copy link
Contributor

pkevan commented Jun 21, 2023

just committing and iterating from there.

That would be my preference here too, as I mention in slack, I can't easily see from the code what is needed or not, and what needs fixing.

@iandunn iandunn force-pushed the events-network branch 3 times, most recently from 1bf0b75 to 34837e1 Compare June 21, 2023 17:16
iandunn added a commit that referenced this pull request Jun 21, 2023
Sites on the new Events network will use the `wordpress.org` wildcard SSL.

See #906

`prepare()` is used because in a future commit `1` will be replaced with `EVENTS_NETWORK_ID`. See #907.
iandunn added a commit that referenced this pull request Jun 21, 2023
Sites on the new Events network will use the `wordpress.org` wildcard SSL.

See #906

`prepare()` is used because in a future commit `1` will be replaced with `EVENTS_NETWORK_ID`. See #907.
@iandunn iandunn merged commit afe21de into production Jun 21, 2023
2 of 3 checks passed
@iandunn iandunn deleted the events-network branch June 21, 2023 21:13
@iandunn
Copy link
Member Author

iandunn commented Jun 21, 2023

This is deployed to production now, and the root site is working.

Event sites like https://events.wordpress.org/narnia/2023/test-site/ need some nginx updates before they'll work.

@iandunn iandunn mentioned this pull request Jun 23, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants