New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup Pilot Events network and URL support #907
Conversation
85ee9ce
to
2985c5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than some nitpicks around what field is used for switching between the two, this seems good to me (Untested) and I don't really understand the hesitation of just committing and iterating from there.
That would be my preference here too, as I mention in slack, I can't easily see from the code what is needed or not, and what needs fixing. |
1bf0b75
to
34837e1
Compare
Co-authored-by: Dion Hulse <dion@wordpress.org>
Co-authored-by: Dion Hulse <dion@wordpress.org>
This is deployed to production now, and the root site is working. Event sites like https://events.wordpress.org/narnia/2023/test-site/ need some nginx updates before they'll work. |
See #884
See #885
This handles the interdependent parts of those issues, which covers everything needed to create sites like
events.wordpress.test/barcelona/2023/diversity-day/
, and have requests routed appropriately.Testing
wp-config.php
andnginx.conf
to be similar to the Docker files in Docker: Add configuration forevents.wordpress.org
network #912. ( I haven't tested Docker yet, though, so more work may be needed in Update Docker env config for Events network #910 to make it work )events.wordpress.test
andevents.wordpress.test/vancouver/2023/diversity-day/
. You'll probably have to use-
instead of/
in the path when creating them, but then you can edit them to change to/
.hosts
filemkcert
to update your SSL certs with the new domainsite_id
for those new sites in thewp_blogs
table to be2
EVENTS_ROOT_BLOG_ID
values to match the blog you created above