Events: Prepare events to fix invalid date error
#1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WordPress/wporg-mu-plugins@ebfc71a applied `prepare_events()` to all code paths callbacks for `google_map_event_filters_{$filter_slug}`. 3a7cccd removed the `timestamp` property from events, because `prepare_events()` adds it dynamically. That commit should have also updated `prime_query_cache()`, since it sets the same transient as `Google_Map\get_events()`. That was missed, and that caused the city landing pages to display `invalid date` after the `events_landing_prime_query_cache` cron job ran.
iandunn
force-pushed
the
prepare-city-landing-events
branch
from
2c66501
to
681e6f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WordPress/wporg-mu-plugins#552 applied
prepare_events()to all code paths callbacks forgoogle_map_event_filters_{$filter_slug}. #1191 removed thetimestampproperty from events, becauseprepare_events()adds it dynamically.That commit should have also updated
prime_query_cache(), since it sets the same transient asGoogle_Map\get_events(). That was missed, and that caused the city landing pages to displayinvalid dateafter theevents_landing_prime_query_cachecron job ran.