Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events: Append facets to the page title #1219

Merged
merged 1 commit into from Jan 22, 2024
Merged

Conversation

iandunn
Copy link
Member

@iandunn iandunn commented Jan 22, 2024

Fixes #1174

This is modeled after how the Showcase does sets the title.

A few examples:

This doesn't affect search results, since Core already handles those and they already include the search query.

@iandunn iandunn added this to the Events: Promotion milestone Jan 22, 2024
@iandunn iandunn self-assigned this Jan 22, 2024
@iandunn iandunn marked this pull request as ready for review January 22, 2024 23:02
@iandunn iandunn merged commit dcde0c3 into production Jan 22, 2024
3 checks passed
@iandunn iandunn deleted the landing-filter-titles branch January 22, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Events: Better SEO titles when filters are applied.
1 participant