Structured Event Data: Include the Event details on past years #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code erroneously suggests that Scheduled should only be for future events, whereas the Scheduled state specifies: > The event is taking place or has taken place on the startDate as scheduled Therefor, Scheduled in the past is valid and should not be interpreted by clients as a future event. This may help with search engines determining the year of the content they're linking to.
The previous commit was too greedy, applying to events that were pre-schedule as well as closed. This reverts it to instead add the closed state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code erroneously suggests that Scheduled should only be for future events, whereas the Scheduled state specifies:
https://schema.org/EventScheduled
Therefor, Scheduled in the past is valid and should not be interpreted by clients as a future event.
This may help with search engines determining the year of the content they're linking to.
See https://wordpress.slack.com/archives/C08M59V3P/p1717047874905299?thread_ts=1717000539.205949&cid=C08M59V3P
Screenshots
How to test the changes in this Pull Request: