PHP 8 fixes for wp_localize_script()
#1022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests will pass on PHP < 8. On PHP 8, only the `Only the first byte will be assigned to the string offset` warning for the `string` test should fail. Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> Co-authored-by: Sergey Biryukov <sergeybiryukov@git.wordpress.org>
…nsupported formats This removes the "Only the first byte will be assigned to the string offset" warning on PHP 8. This also adds a `_doing_it_wrong()` warning for all unsupported data formats. Includes minor adjustments to the test to expect the `_doing_it_wrong()` warning. Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> Co-authored-by: Sergey Biryukov <sergeybiryukov@git.wordpress.org>
jrfnl
changed the title
wp_localize_script()
|
Merged with changeset https://core.trac.wordpress.org/changeset/50408 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/52534
Replaces patch PR: #1007
Commit 1: WP_Scripts::localize: add tests with different data formats
These tests will pass on PHP < 8.
On PHP 8, only the
Only the first byte will be assigned to the string offsetwarning for thestringtest should fail.Commit 2: WP_Scripts::localize: fix PHP 8 issue and add _doing_it_wrong() for unsupported formats
This removes the "Only the first byte will be assigned to the string offset" warning on PHP 8.
This also adds a
_doing_it_wrong()warning for all unsupported data formats.Includes minor adjustments to the test to expect the
_doing_it_wrong()warning.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.