Merge conflicting wp.editor objects into a single, non-conflicting module #1481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves WordPress/gutenberg#33203
Solves https://core.trac.wordpress.org/ticket/53437
Related to https://core.trac.wordpress.org/ticket/53569
Situation:
packages/editor
is exposed aswindow.wp.editor
in wp-adminProblem: there is quite some code expecting to see a different (legacy) object under
window.wp.editor
Proposed solution: export all the members of legacy window.wp.editor from this new module to maintain backward compatibility
As @noisysocks noticed in WordPress/gutenberg#33228:
This is addressed in #1484
How has this been tested?
Screenshots
(Credits for the screenshot and the test plan to @spacedmonkey)
Types of changes
Bug fix (non-breaking change which fixes an issue)