phpunit test for wp_nonce_ays AND UPDATE CODE for wp_die_handler to p… #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass the response into WPDieException so that expectExceptionCode() call works
…context in get_block_categories() function calls
jrfnl
reviewed
Aug 10, 2021
| */ | ||
| public function test_wp_nonce_ays_log_out() { | ||
| $this->expectException( 'WPDieException' ); | ||
| $this->expectExceptionMessageRegExp( '/You are attempting to log out of Test Blog<\/p><p>Do you really want to <a href="http:\/\/example\.org\/wp-login\.php\?action=logout&_wpnonce=.{10}">log out<\/a>\?/m' ); |
There was a problem hiding this comment.
Suggested change
| $this->expectExceptionMessageRegExp( '/You are attempting to log out of Test Blog<\/p><p>Do you really want to <a href="http:\/\/example\.org\/wp-login\.php\?action=logout&_wpnonce=.{10}">log out<\/a>\?/m' ); | |
| $this->expectExceptionMessageMatches( '/You are attempting to log out of Test Blog<\/p><p>Do you really want to <a href="http:\/\/example\.org\/wp-login\.php\?action=logout&_wpnonce=.{10}">log out<\/a>\?/m' ); |
There was a problem hiding this comment.
The test suite has been upgraded for better PHPUnit cross-version compatibility. You can now use all PHPUnit 9.x assertion and expectation methods and the tests will still work on PHPUnit 5.x - 9.x.
For more details, see https://core.trac.wordpress.org/ticket/46149
There was a problem hiding this comment.
I saw that the tests were failing and fixed already
|
Thanks for the PR! Merged in https://core.trac.wordpress.org/changeset/51608. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests for wp_nonce_ays
AND UPDATE CODE for wp_die_handler to pass the response into WPDieException so that expectExceptionCode() call work
Trac ticket: https://core.trac.wordpress.org/ticket/53882