Not possible to get a post type's REST API namespace if modified #1749
Conversation
src/wp-includes/rest-api/endpoints/class-wp-rest-post-types-controller.php
Outdated
Show resolved
Hide resolved
| $this->rest_base = 'autosaves'; | ||
| $this->namespace = ! empty( $post_type_object->rest_namespace ) ? $post_type_object->rest_namespace : 'wp/v2'; |
There was a problem hiding this comment.
Are these checks necessary? AFAICT, we set a default value for the namespace in the post type object, so it should never be empty, correct?
There was a problem hiding this comment.
( Same for other instances of the same check )
There was a problem hiding this comment.
My worry here, that there is post type object is created in a strange way and that somehow this property does not exist. Or that it is set to false for some reason. This is just a little hardnessing.
src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php
Outdated
Show resolved
Hide resolved
src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php
Outdated
Show resolved
Hide resolved
|
Tests look great, thanks @spacedmonkey! Just a question about the naming. |
Function change name to |
spacedmonkey
force-pushed
the
try/post-namespace
branch
from
e37480a
to
766b6b4
Compare
src/wp-includes/rest-api/endpoints/class-wp-rest-post-types-controller.php
Outdated
Show resolved
Hide resolved
|
So upon further review, we are going to need to remove the specific controller class checks from this method as well as the |
I noticed this myself. I was going to note it the dev blog after release. I wasn't 100% why the check was in the there in the first place, felt like over kill to me. I also don't like that you have to spin up a instance of the class to do this check. Much cleaner to just use the |
|
Update the patch based on feedback. |
TimothyBJacobs
force-pushed
the
try/post-namespace
branch
2 times, most recently
from
0b9b1c8
to
d6b1631
Compare
Use rest_get_route_for_post in for media. Add rest_get_route_for_post_type function. use show_in_rest. Apply suggestions from code review Update src/wp-includes/class-wp-post-type.php More tweaks Update fixtures. Update spacing. Improve tests. Improve tests. Change function name. Update src/wp-includes/rest-api/endpoints/class-wp-rest-post-types-controller.php Remove checks for class instances. Use rest_get_route_for_post_type_items in more places use in rest_get_route_for_post_type_items in rest_get_route_for_post
TimothyBJacobs
force-pushed
the
try/post-namespace
branch
from
d6b1631
to
9f0f7c4
Compare
Trac ticket: https://core.trac.wordpress.org/ticket/53656
GB issue: WordPress/gutenberg#33420
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.