Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns REST API: Add 'inserter' to the schema #2600

Closed

Conversation

Mamaduka
Copy link
Member

Backports changes from WordPress/gutenberg#40416

Adds the missing inserter field to the Patterns item schema.
Currently, this field is omitted from the response, and patterns that should be hidden in the inserter are visible.

Props, @ndiego, for discovering a bug and testing the fix.

Trac ticket: https://core.trac.wordpress.org/ticket/55567


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. We use the default text domain in WP core, but otherwise looks great 👍🏻

@gziolo
Copy link
Member

gziolo commented Apr 19, 2022

Committed with https://core.trac.wordpress.org/changeset/53210.

@gziolo gziolo closed this Apr 19, 2022
@Mamaduka
Copy link
Member Author

Sorry about copy-pasta, @gziolo.

@gziolo
Copy link
Member

gziolo commented Apr 19, 2022

Sorry about copy-pasta, @gziolo.

Actually, it'd be perfectly fine to avoid using the text domain in the Gutenberg plugin in files that we know are meant to be moved to core 😄

@Mamaduka Mamaduka deleted the add/patterns-api-inserter-to-schema branch September 13, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
2 participants