Patterns API: Add 'inserter' to the schema #40416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Thanks for this @Mamaduka! This PR fixes the root issue, both for patterns registered via JS and PHP in the |
ndiego
approved these changes
Apr 18, 2022
|
@Mamaduka, once merged, let's add the backport tag. This should get in 6.0. |
|
Thanks, @ndiego. I think those are flaky tests. |
Mamaduka
force-pushed
the
fix/patterns-api-inserter-schema
branch
from
8db2271
to
c3a085c
Compare
Mamaduka
added
the
Backport to WP 6.6 Beta/RC
|
@adamziel, @gziolo, here's WP core PR - WordPress/wordpress-develop#2600. |
gziolo
removed
the
Backport to WP 6.6 Beta/RC
Actually, there is nothing to do about this PR in the context of WordPress core. Let's add the linked PR in core to the project. |
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Apr 19, 2022
Backports changes from WordPress/gutenberg#40416. Adds the missing `inserter` field to the Patterns item schema. This field was omitted from the response, and patterns that should be hidden in the inserter were visible. Props mamaduka, ndiego. See #55567. Follow-up [53152]. git-svn-id: https://develop.svn.wordpress.org/trunk@53210 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Apr 19, 2022
Backports changes from WordPress/gutenberg#40416. Adds the missing `inserter` field to the Patterns item schema. This field was omitted from the response, and patterns that should be hidden in the inserter were visible. Props mamaduka, ndiego. See #55567. Follow-up [53152]. Built from https://develop.svn.wordpress.org/trunk@53210 git-svn-id: http://core.svn.wordpress.org/trunk@52799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to gilzow/wordpress-performance
that referenced
this pull request
Apr 19, 2022
Backports changes from WordPress/gutenberg#40416. Adds the missing `inserter` field to the Patterns item schema. This field was omitted from the response, and patterns that should be hidden in the inserter were visible. Props mamaduka, ndiego. See #55567. Follow-up [53152]. Built from https://develop.svn.wordpress.org/trunk@53210 git-svn-id: https://core.svn.wordpress.org/trunk@52799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #40414.
PR adds the missing
inserterfield to the Patterns item schema.Why?
Currently, this field is omitted from the response, and patterns that should be hidden in the inserter are visible.
Testing Instructions