Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wp_after_tag_search filter #2620

Closed
wants to merge 15 commits into from
Closed

Add wp_after_tag_search filter #2620

wants to merge 15 commits into from

Conversation

grandeljay
Copy link

@grandeljay grandeljay commented Apr 22, 2022

https://core.trac.wordpress.org/ticket/55606

I want to create a plugin which suggests existing tags, if they are similar to existing tags. For this I want to hook into the term results, but it seems there is no way to. This filter should solve that.

image

@github-actions
Copy link

Hi @grandeljay! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

Copy link
Contributor

@costdev costdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have left some thoughts below.

src/wp-admin/includes/ajax-actions.php Outdated Show resolved Hide resolved
Copy link
Contributor

@costdev costdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more suggested changes and then I think this is ready for commit consideration when the 6.1 branch opens.

Nice work @grandeljay!

tests/phpunit/tests/ajax/TagSearch.php Outdated Show resolved Hide resolved
tests/phpunit/tests/ajax/TagSearch.php Outdated Show resolved Hide resolved
tests/phpunit/tests/ajax/TagSearch.php Outdated Show resolved Hide resolved
grandeljay and others added 3 commits April 26, 2022 05:58
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
@grandeljay
Copy link
Author

I think I figured out what went wrong with the unit test. It should work now 👍🏼

Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Copy link
Contributor

@costdev costdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

audrasjb and others added 3 commits July 26, 2022 13:10
Co-authored-by: Sergey Biryukov <sergeybiryukov.ru@gmail.com>
Co-authored-by: Sergey Biryukov <sergeybiryukov.ru@gmail.com>
Copy link
Member

@SergeyBiryukov SergeyBiryukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! 👍

@audrasjb
Copy link
Contributor

Committed in https://core.trac.wordpress.org/changeset/53781

@audrasjb audrasjb closed this Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants