-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strong tags forgotten for warnings #2666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Fixes 54437
I should have checked the other branches before submitting this PR... Now, I have found another one. All branches have been checked and I think I got them. |
I saved the wrong commit...
@NekoJonez tests are now failing though:
You need to also update unit tests :) |
As a noob in this, some help with that would be nice. |
@ocean90 , I removed all strong tags in the AJAX php file... And tests are still failing. |
@NekoJonez I opened another PR to fix the failing unit tests: #2669 |
@audrasjb Excellent. Now I dont have to worry about why my things are failing. |
Closing in favor of #2669 |
During development of 6.0, a trac ticket of mine was fixed. This was adding strong tags in warnings. Yet, during translation I found two others.
Trac ticket: (https://core.trac.wordpress.org/ticket/54437)
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.