Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong tags forgotten for warnings #2666

Closed
wants to merge 5 commits into from

Conversation

NekoJonez
Copy link

During development of 6.0, a trac ticket of mine was fixed. This was adding strong tags in warnings. Yet, during translation I found two others.

Trac ticket: (https://core.trac.wordpress.org/ticket/54437)


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link
Contributor

@costdev costdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@NekoJonez
Copy link
Author

NekoJonez commented May 3, 2022

I should have checked the other branches before submitting this PR... Now, I have found another one. All branches have been checked and I think I got them.

I saved the wrong commit...
@audrasjb
Copy link
Contributor

audrasjb commented May 3, 2022

@NekoJonez tests are now failing though:

1) Tests_Ajax_ReplytoComment::test_with_draft_post
Failed asserting that exception message '<strong>Error:</strong> You cannot reply to a comment on a draft post.' contains 'Error: You cannot reply to a comment on a draft post.'.

You need to also update unit tests :)

@NekoJonez
Copy link
Author

@NekoJonez tests are now failing though:

1) Tests_Ajax_ReplytoComment::test_with_draft_post
Failed asserting that exception message '<strong>Error:</strong> You cannot reply to a comment on a draft post.' contains 'Error: You cannot reply to a comment on a draft post.'.

You need to also update unit tests :)

As a noob in this, some help with that would be nice.

@NekoJonez
Copy link
Author

@ocean90 , I removed all strong tags in the AJAX php file... And tests are still failing.
Do those strong tags also need to be removed in the other files?

@audrasjb
Copy link
Contributor

audrasjb commented May 3, 2022

@NekoJonez I opened another PR to fix the failing unit tests: #2669
Does it look good to you?

@NekoJonez
Copy link
Author

@NekoJonez I opened another PR to fix the failing unit tests: #2669
Does it look good to you?

@audrasjb Excellent. Now I dont have to worry about why my things are failing.

@audrasjb
Copy link
Contributor

audrasjb commented May 3, 2022

Closing in favor of #2669

@audrasjb audrasjb closed this May 3, 2022
@NekoJonez NekoJonez deleted the patch-3 branch June 13, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants