Feature Project/Feature Plugin for Plugin Dependencies #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afragen
force-pushed
the
dependencies-tab
branch
2 times, most recently
from
d31e836
to
6b6ccb1
Compare
|
Somehow I need to remove |
…ze_during_tests Plugin Dependencies: Require the class in Core's bootstrap, but just don't initialize it during tests.
…instead_of_creating_new_ones Plugin Dependencies: Store reflected members instead of creating new ones in tests.
…_convert_to_slug Plugin Dependencies: Add a test to ensure that `hello.php` is converted to `hello-dolly`.
Plugin Dependencies: Make modals persistent for Install Now, Activate and Update Now.
Plugin Dependencies: Fix issues reported by JSHint.
…in_data Plugin Dependencies: Fix the key `get_plugins()` sets when updating plugin data.
Plugin Dependencies: Tests update
Plugin Dependencies: Fix circular dependencies
|
Thanks for the PR! Committed in r57545. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Feature Project for Plugin Dependencies has been created. Along with this a Feature Plugin has also been created.
Testing either via this PR or the feature plugin will show similar/identical results.
Trac ticket: https://core.trac.wordpress.org/ticket/22316
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.