Check if $authordata is not false before trying to read property
#3141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
reviewed
Sep 6, 2022
src/wp-includes/link-template.php
Outdated
| @@ -262,7 +262,10 @@ function get_permalink( $post = 0, $leavename = false ) { | |||
| $author = ''; | |||
| if ( strpos( $permalink, '%author%' ) !== false ) { | |||
| $authordata = get_userdata( $post->post_author ); | |||
| $author = $authordata->user_nicename; | |||
|
|
|||
| if ( false !== $authordata ) { | |||
There was a problem hiding this comment.
Suggested change
| if ( false !== $authordata ) { | |
| if ( $authordata instanceof WP_User ) { |
Always better to verify that the type if the type want, rather than comparing against one of the many types you don't want.
Would also be good to see a test covering this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent PHP warning when reading user_nicename property from
$authordatavariableTrac ticket: https://core.trac.wordpress.org/ticket/56229
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.