GH Actions: do not allow tests to fail for select PHP 8.1 test runs #3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests being run in these particular test groups are passing on PHP 8.1, however, the test runs are still allowed to "continue on error". This creates the risk that new PHP 8.1 incompatibilities will be introduced without anyone noticing. By no longer allowing these test runs to "continue on error", that risk is removed.
|
Thanks for the PR! Merged in r54072. |
|
Thanks for the quick merge @SergeyBiryukov ! |
jrfnl
deleted the
trac-55656/ghactions-dont-continue-on-error-when-not-needed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憠馃徎 This PR is part of a series of PRs to get the builds passing on PHP 8.1 (to prevent having to also allow failures on PHP 8.2, even when the PHP 8.2 issues are fixed (for a certain definition of "fixed")).
The tests being run in these particular test groups are passing on PHP 8.1, however, the test runs are still allowed to "continue on error".
This creates the risk that new PHP 8.1 incompatibilities will be introduced without anyone noticing.
By no longer allowing these test runs to "continue on error", that risk is removed.
Trac ticket: https://core.trac.wordpress.org/ticket/55656
Trac ticket: https://core.trac.wordpress.org/ticket/55652
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.