Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding menus route #319

Closed
wants to merge 8 commits into from
Closed

Conversation

spacedmonkey
Copy link
Member

Feature plugin - https://github.com/WP-API/menus-endpoints

Trac ticket: https://core.trac.wordpress.org/ticket/40878


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@TimothyBJacobs
Copy link
Member

We need to add @ticket annotations for the tests.

I'm also going to hold off on committing this until the Gutenberg merge happens for 5.5.

@spacedmonkey
Copy link
Member Author

We need to add @ticket annotations for the tests.

I'm also going to hold off on committing this until the Gutenberg merge happens for 5.5.

Ticket number and version number comments added.

@ellatrix
Copy link
Member

Is this for the navigation screen? If so, not sure if it should be merged now.

@TimothyBJacobs
Copy link
Member

Is this for the navigation screen? If so, not sure if it should be merged now.

Yes. I removed it from the milestone Saturday.

@spacedmonkey
Copy link
Member Author

Closing in favour #1814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants