[ Navigation Screen ] Enables the new navigation screen to set up menus that auto add new pages #22697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +223 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
spacedmonkey
requested changes
May 28, 2020
draganescu
changed the title
draganescu
force-pushed
the
add/auto-add-pages-navigation
branch
from
2e91f3f
to
64fd304
Compare
|
Howdy @spacedmonkey is this enough? I just set the new param true and check for that. |
|
@draganescu Do you mind if I jump in and rewrite the php here ? |
|
Howdy @spacedmonkey I don't mind :) but this is the 1st thing I do that's related to this part of WP (ever) so I fear I'll never learn like that. Lot's of copy pasta in there I know. I'll address your review and then if you still want to you can take over? Thank you 🙏 |
TimothyBJacobs
requested changes
Jun 17, 2020
|
Updated - WordPress/wordpress-develop#319 |
draganescu
force-pushed
the
add/auto-add-pages-navigation
branch
from
a38f5d3
to
1c08545
Compare
also implements an UI to set auto_add in the new menu editor
Co-authored-by: Timothy Jacobs <timothy@ironbounddesigns.com>
Co-authored-by: Timothy Jacobs <timothy@ironbounddesigns.com>
Co-authored-by: Timothy Jacobs <timothy@ironbounddesigns.com>
Co-authored-by: Timothy Jacobs <timothy@ironbounddesigns.com>
draganescu
force-pushed
the
add/auto-add-pages-navigation
branch
from
1c08545
to
d211cf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21311
Description
This PR adds a new
auto_addproperty to the__experimental/menusREST endpoint. This property is the same as the one in the currentwp_nav_menu_update_menu_items.It also adds a checkbox to each menu that sets
auto_addHow has this been tested?
Tested locally by:
nav-menus.phpScreenshots
Types of changes
Non breaking changes, adds
auto_addto the schema of Menu and a checkbox with state to theBlockEditorPanelcomponent.cc @TimothyBJacobs @spacedmonkey