Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding Standards: Use more meaningful variable names in Theme Upgrader. #3196

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

costdev
Copy link
Contributor

@costdev costdev commented Sep 5, 2022

Per naming conventions, don’t abbreviate variable names unnecessarily; let the code be unambiguous and self-documenting.

See PHP Coding Standards - Naming Conventions.

This PR includes renaming of the following variables:

  • $r to $upgrade_data.
  • $res to $connected.
  • $info to $new_theme_data.

Trac ticket: https://core.trac.wordpress.org/ticket/55647

costdev added 3 commits September 5, 2022 18:31
…s/class-theme-upgrader.php`.

Per naming conventions, don’t abbreviate variable names unnecessarily;
let the code be unambiguous and self-documenting.
…/class-theme-upgrader.php`.

Per naming conventions, don’t abbreviate variable names unnecessarily;
let the code be unambiguous and self-documenting.
…cludes/class-theme-upgrader.php`.

Per naming conventions, don’t abbreviate variable names unnecessarily;
let the code be unambiguous and self-documenting.
@costdev costdev marked this pull request as ready for review September 5, 2022 23:30
@mukeshpanchal27
Copy link
Member

@costdev great work 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants