Author caching in WP_Query::the_post() can trigger an error. #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two things are tested: 1) That requesting post objects warms the author cache 2) That requesting a subset of fields will not throw an error
peterwilsoncc
force-pushed
the
fix/56948-warm-authors-with-post-objects
branch
from
f09540d
to
c9502de
Compare
spacedmonkey
reviewed
Nov 3, 2022
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
spacedmonkey
reviewed
Nov 4, 2022
src/wp-includes/class-wp-query.php
Outdated
Comment on lines
3574
to
3575
| $post_ids = array_filter( $this->posts, 'is_numeric' ); | ||
| $post_ids = array_filter( $post_ids ); |
There was a problem hiding this comment.
Suggested change
| $post_ids = array_filter( $this->posts, 'is_numeric' ); | |
| $post_ids = array_filter( $post_ids ); | |
| $post_ids = array_filter( array_filter( $this->posts, 'is_numeric' ) ); |
We could do this, might be a little cleaner.
There was a problem hiding this comment.
I'd pushed 3b5fca1 before seeing this, on the basis that comments are needed to explain why array_filter is called twice.
peterwilsoncc
commented
Nov 7, 2022
| _prime_post_caches( $post_ids, $this->query_vars['update_post_term_cache'], $this->query_vars['update_post_meta_cache'] ); | ||
| } | ||
| $post_objects = array_map( 'get_post', $this->posts ); | ||
| update_post_author_caches( $post_objects ); |
There was a problem hiding this comment.
It occurs to me, this will have a similar problem to #56952 and throw an error if called before pluggable functions are loaded.
It might be worth returning early in update_post_author_caches() if cache_users() is undefined.
spacedmonkey
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://core.trac.wordpress.org/ticket/56948
The first commit ensures the tests are failing prior to the changes, the second to only warm the cache when
WP_Query::$postsis populated withWP_Postobjects.