test for wp_maybe_load_widgets

[pbearne]

Trac ticket: https://core.trac.wordpress.org/ticket/57201

[costdev]

Thanks for the PR @pbearne and for working to implement standards early to save time in reviewing / implementing review feedback! Much appreciated and look forward to seeing that in future PRs!

I've left some thoughts below which should help with an unmet standard (message parameter) and test stability. 🙂

[costdev]

Suggested change

	*/#
	*/

There was just a stray # here

[costdev]

A couple of thoughts:

1. Test methods with multiple assertions should have a message parameter to explain what went wrong.

For similar assertions (i.e. multiple assertion of class_exists()), the message can be:

• WP_Nav_Menu_Widget should not exist before doing something.
• WP_Nav_Menu_Widget should not exist after doing something.
• WP_Nav_Menu_Widget should exist after doing something.

2. It may be best to split this into two test methods:

• test_wp_maybe_load_widgets_should_respect_falsy_load_default_widgets_filter() - Use a data provider with falsy values to send to the filter hook via static closure, then assertFalse() for class_exists() and has_action().
• test_wp_maybe_load_widgets_should_load_widgets() - assertFalse() for class_exists() and has_action(), then call wp_maybe_load_widgets(), then assertTrue() on class_exists() and has_action() (all assertions should have the message parameter)