Alternative: Filesystem API: Introduce pre_unzip_file and unzip_file filter hooks.
#4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costdev
force-pushed
the
simplified_introduce_pre_unzip_file_and_post_unzip_file
branch
from
6c259cf
to
2879828
Compare
costdev
changed the title
pre_unzip_file and post_unzip_file hooks.before_unzip_file and after_unzip_file hooks.
costdev
force-pushed
the
simplified_introduce_pre_unzip_file_and_post_unzip_file
branch
from
2879828
to
a8e650b
Compare
costdev
force-pushed
the
simplified_introduce_pre_unzip_file_and_post_unzip_file
branch
from
a8e650b
to
f79c5ee
Compare
costdev
commented
Sep 11, 2023
costdev
force-pushed
the
simplified_introduce_pre_unzip_file_and_post_unzip_file
branch
from
f79c5ee
to
3468d35
Compare
costdev
changed the title
before_unzip_file and after_unzip_file hooks.pre_unzip_file and unzip_file filter hooks.
afragen
reviewed
Sep 23, 2023
costdev
force-pushed
the
simplified_introduce_pre_unzip_file_and_post_unzip_file
branch
from
b20c999
to
649b4a3
Compare
|
Committed in r56689. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces two new filters:
pre_unzip_fileandunzip_file.pre_unzip_fileallows overriding the unzipping logic with a custom implementation.unzip_fileallows filtering the result of unzipping. This can be used to perform malware scans, for example.Both filters pass the following:
string $file- Full path and filename of ZIP archive.string $to- Full path on the filesystem to extract archive to.string[] $needed_dirs- A full list of required folders needed to be created.float|false $required_space- The space required to unzip the file and copy its contents, with a 10% buffer. False ifdisk_free_space()returnedfalse.Trac ticket: https://core.trac.wordpress.org/ticket/37719