Update sodium_compat to 1.20.0. #4400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costdev
commented
Apr 30, 2023
| @@ -1360,6 +1360,8 @@ function sodium_memcmp($string1, $string2) | |||
| * @return void | |||
| * @throws SodiumException | |||
| * @throws TypeError | |||
| * | |||
| * @psalm-suppress ReferenceConstraintViolation | |||
There was a problem hiding this comment.
While this isn't strictly necessary, it seemed like this change was worth adding to minimize differences with the original source.
paragonie-security
approved these changes
Apr 30, 2023
mukeshpanchal27
approved these changes
Apr 30, 2023
|
Thanks for the PR! Merged in r55699. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of sodium_compat includes a fix for the Poly1305 implementation.
Release Notes:
https://github.com/paragonie/sodium_compat/releases/tag/v1.20.0
A full list of changes in this update can be found on GitHub:
paragonie/sodium_compat@v1.19.0...v1.20.0
Trac ticket: https://core.trac.wordpress.org/ticket/58224