Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media: Only show Copy and Download actions when an attachment URL is available. #4651

Conversation

costdev
Copy link
Contributor

@costdev costdev commented Jun 20, 2023

@costdev costdev force-pushed the tests_wp_media_list_table_get_row_actions branch 5 times, most recently from f878529 to 3bd12a0 Compare June 20, 2023 18:21
@costdev costdev marked this pull request as ready for review June 20, 2023 18:44
@costdev costdev force-pushed the tests_wp_media_list_table_get_row_actions branch from 18a457b to 319730f Compare June 20, 2023 19:35
@kebbet
Copy link

kebbet commented Jun 21, 2023

The PR looks good, looking at the media table part. I'm a novice at tests, so can not really say anything about them.

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @costdev for the PR. Seems you cover all the tests cases 🚀

@SergeyBiryukov
Copy link
Member

Thanks for the PR! Merged in r56072.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants