#59118 Remove support for the mysql extension #5017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbillion
changed the title
johnbillion
requested review from
SergeyBiryukov,
desrosj,
jrfnl and
felixarntz
|
@johnbillion The PR have list of PHPCS issues that need to fix. |
|
@mukeshpanchal27 Yeah they should all be about indentation as mentioned in the PR description. I didn't fix the indentation in order to keep the diff clean and it can be addressed in the commit. |
felixarntz
reviewed
Aug 17, 2023
There was a problem hiding this comment.
Thanks @johnbillion, this looks pretty much good to go from my perspective (other than the PHPCS failures, which you pointed out you'll fix pre-commit).
Two small notes of feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/59118
This removes the conditional
mysqlsupport fromwpdband elsewhere that's no longer needed nor used since WordPress 6.3 bumped the minimum supported PHP version to 7.0.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.