Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: enable test runs against PHP 8.3 #5106

Closed

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Aug 28, 2023

Providing PRs #4887 and #5105 are committed first, this PR can go in without the need for a continue-on-error as the build will pass on PHP 8.3.

Trac ticket: https://core.trac.wordpress.org/ticket/59231


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@jrfnl jrfnl force-pushed the trac-59231/ghactions-run-tests-on-php-8.3 branch 2 times, most recently from 1ed269b to 9944428 Compare August 28, 2023 23:40
Providing PRs 4887 and 5105 are committed first, this PR can go in without the need for a `continue-on-error` as the build will pass on PHP 8.3.
@SergeyBiryukov SergeyBiryukov force-pushed the trac-59231/ghactions-run-tests-on-php-8.3 branch from 9944428 to 5827272 Compare August 31, 2023 07:59
@SergeyBiryukov
Copy link
Member

SergeyBiryukov commented Aug 31, 2023

Thanks for the PR!

With the prerequisite PRs both merged, it appears that the build still fails on Xdebug tests:

error: 'xdebug' does not exist

Apparently the Docker image for PHP 8.3 does not contain Xdebug yet, so we might need to disable those tests for now, like we did for PHP 8.2 in r53922.

@jrfnl
Copy link
Member Author

jrfnl commented Aug 31, 2023

Thanks for the PR!

With the prerequisite PRs both merged, it appears that the build still fails on Xdebug tests:

error: 'xdebug' does not exist

Apparently the Docker image for PHP 8.3 does not contain Xdebug yet, so we might need to disable those tests for now, like we did for PHP 8.2 in r53922.

Ah, yes, of course! Xdebug for PHP 8.3 is not yet available, we're ready for PHP 8.3 too early ... 🤪

I'm currently in a workshop. If you like, I'll have a look at this tonight and rebase the PR as well. Does that work for you ?

@SergeyBiryukov
Copy link
Member

Ah, yes, of course! Xdebug for PHP 8.3 is not yet available

Thanks for the confirmation 🙂 I have added a conditional to skip Xdebug-related tests for the time being, and the build is passing now 🎉 Merged in r56498.

@jrfnl jrfnl deleted the trac-59231/ghactions-run-tests-on-php-8.3 branch August 31, 2023 12:31
@jrfnl
Copy link
Member Author

jrfnl commented Aug 31, 2023

Thanks @SergeyBiryukov ! This means the base PHP 8.3 compatibility for WP Core is now done and WP Core can now be called "beta-compatible" (with the caveats of the three split off tickets with some known improvements to make, though those are not necessarily incompatibilities with PHP 8.3).

/cc @hellofromtonya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants