Fixed Avatar Design Issue in Editor in Twenty Nineteen theme #5426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukeshpanchal27
suggested changes
Oct 8, 2023
There was a problem hiding this comment.
Thanks @shail-mehta for the PR, left some feedback that needs to address.
Comment on lines
1608
to
1612
|
|
||
| /* Post Author Block */ | ||
| .editor-styles-wrapper .avatar, .editor-styles-wrapper .wp-block-post-author__avatar img { | ||
| border-radius: 50%; | ||
| } |
There was a problem hiding this comment.
The CSS will auto generate based on SCSS when it build, Could you please remove this changes?
| @@ -1020,3 +1020,13 @@ $group-block-background__padding: $font__size_base; | |||
| width: 100%; | |||
| } | |||
| } | |||
|
|
|||
| /* Post Author Block */ | |||
There was a problem hiding this comment.
Suggested change
| /* Post Author Block */ | |
| /** === Post Author Block === */ |
Use same formate for comment.
| border-radius: 50%; | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Add empty line at the end of CSS.
|
Thank you for the feedback @mukeshpanchal27. I have Updated PR as per mentioned Feedback changes.
|
sabernhardt
suggested changes
Oct 11, 2023
| @@ -1604,4 +1604,4 @@ ul.wp-block-archives li ul, | |||
| padding-left: 0; | |||
| padding-right: 0; | |||
| width: 100%; | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Please restore the empty line at the end of the file.
(Whoever commits the change could compile this stylesheet from the SCSS, but the file should remain unchanged if it is not compiled within the pull request.)
There was a problem hiding this comment.
I have Restored Last empty line.
Comment on lines
1026
to
1033
| .editor-styles-wrapper { | ||
|
|
||
| & .avatar, | ||
| & .wp-block-post-author__avatar img { | ||
| border-radius: 50%; | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Suggested change
| .editor-styles-wrapper { | |
| & .avatar, | |
| & .wp-block-post-author__avatar img { | |
| border-radius: 50%; | |
| } | |
| } | |
| .avatar, | |
| .wp-block-post-author__avatar img { | |
| border-radius: 100%; | |
| } |
Twenty Nineteen's editor styles automatically add the .editor-styles-wrapper selector. Also, while 50% may look like 100%, Twenty Nineteen uses 100% for the front end.
There was a problem hiding this comment.
@sabernhardt I have updated changes as per mentioned.
The recently introduced Block Hooks API exposes a filter (`hooked_block_types`) which is given a `$context` argument, among others. If the filter is called on a block that's part of a template or template part, `$context` is set to the corresponding `WP_Block_Template` object. However, that object's `$content` property is currently ''not'' exposed to the filter. This changeset amends that shortcoming. This is useful for callbacks that might want to detect the presence of a serialized block instance (or potentially in the future utilize the HTML API) to restrict where the block is injected (before the template is rendered). Addressing this also achieves parity with the structure of `$context` when it represents a pattern (where pattern serialized content is present). Props nerrad. Fixes #59882. git-svn-id: https://develop.svn.wordpress.org/trunk@57118 602fd350-edb4-49c9-b593-d223f7449a82
…n standards. Follow-up to [56834], [56836], [56837], [56838]. Props kebbet, costdev, mukesh27, SergeyBiryukov. See #59651. git-svn-id: https://develop.svn.wordpress.org/trunk@57120 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [54173]. Props kitchin. See #55646, #59651. git-svn-id: https://develop.svn.wordpress.org/trunk@57121 602fd350-edb4-49c9-b593-d223f7449a82
In preparation for updating Core to use Node.js version 18.x, this updates the dependancies for the Twenty Twenty-One theme to the latest versions. This addresses an unsupported engine warning where packages within the dependency tree did not support Node.js > 16.x. All changes to built files are included in this commit. These changes are a result of the following: - Identical sets of properties for multiple selectors are now consolidated into one. - The removal of a duplicate `--branding--description--font-family` definition. - The addition of the `postcss-discard-empty` dependency, which removes empty CSS rules within IE stylesheets after the previous consolidation is performed. - `stylelint` has only been updated to 14.x (15.x is the latest). This is because `@wordpres/stylelint-config` currently has a version constraint of `^14.2` and does not properly support 15.x. The last change of note is the new configuration for the `value-keyword-case` rule in `.stylelint-css.json`. This was added as a way to prevent the `currentColor` from being changed to all lowercase. Props jorbin, poena. See #59663, #59658. git-svn-id: https://develop.svn.wordpress.org/trunk@57122 602fd350-edb4-49c9-b593-d223f7449a82
…dability. This aims to: * Perform the checks as early as possible to avoid redundant function calls. * Remove an empty conditiaonal branch and make the exit conditions clearer. * Bring the formatting in line with other multi-line conditionals in core. Follow-up to [56836]. See #59650. git-svn-id: https://develop.svn.wordpress.org/trunk@57123 602fd350-edb4-49c9-b593-d223f7449a82
After [56958], pull requests to `wordpress-develop` can be tested within a WordPress Playground instance. However this capability is not obvious. This makes several updates to GitHub action workflows to avoid unnecessary extra runs/jobs while also commenting on pull requests with proper context for testing in Playground once a build is available for the PR. Changes: - The `build.yml` workflow has been deleted. The WordPress build process is already being tested within the `test-build-processes.yml` workflow. Now that workflow will produce and upload the built artifact for the given PR. - A `pull-request-comments.yml` workflow has been added to handle the commenting. To avoid having multiple workflows that comment on PRs, the logic within the `welcome-new-contributors.yml` workflow has been merged into this one. - The `pull_request` event trigger lacks the needed permission to comment on or update pull requests. Instead of using `pull_request_target` to navigate around this, the `test-build-processes.yml` workflow will now use `workflow_dispatch` to initiate a run of the commenting workflow. This adds the ability to only comment on the PR when a build has been successfully created and uploaded as an artifact. Props swissspidy, zieladam, jeffpaul. See #59416. git-svn-id: https://develop.svn.wordpress.org/trunk@57124 602fd350-edb4-49c9-b593-d223f7449a82
When this job fails, it should not fail the entire workflow. The next update to the pull request will attempt to dispatch the commenting workflow. Follow up to [57124]. Props johnbillion. See #59416. git-svn-id: https://develop.svn.wordpress.org/trunk@57125 602fd350-edb4-49c9-b593-d223f7449a82
…_request()`. Follow-up to [55703], [56834]. See #59650. git-svn-id: https://develop.svn.wordpress.org/trunk@57126 602fd350-edb4-49c9-b593-d223f7449a82
…ption. Follow-up to [56951]. Props gavande1, acosmin, afercia, huzaifaalmesbah, ironprogrammer. Fixes #59840. git-svn-id: https://develop.svn.wordpress.org/trunk@57127 602fd350-edb4-49c9-b593-d223f7449a82
This commit updates the `submit_button()` function to standardize the default values of `$text` and `$other_attributes` parameters. Previously set to `null`, these defaults have now been changed to an empty string (`''`), bringing consistency with the `get_submit_button()` function, which `submit_button()` wraps. The change maintains backward compatibility, as `get_submit_button()` does not perform strict type-checking on these parameters. This update aligns with the ongoing effort to standardize function parameters across the WordPress codebase, improving the readability and predictability of the core functions. Follow-up to [31446]. Props andbalashov. Fixes #59921. git-svn-id: https://develop.svn.wordpress.org/trunk@57128 602fd350-edb4-49c9-b593-d223f7449a82
This fixes bugs introduced in [56635] whereby the template or stylesheet path could be memoized incorrectly if `get_template_directory()` or `get_stylesheet_directory()` were called before the theme has been fully initialized. Props partyfrikadelle, coreyw, kdowns, rebasaurus, meta4, flixos90, mukesh27, joemcgill. Fixes #59847. git-svn-id: https://develop.svn.wordpress.org/trunk@57129 602fd350-edb4-49c9-b593-d223f7449a82
`wp_json_encode()` is a wrapper for the PHP native `json_encode()` function with some extra safety checks. This commit renames the `$data` parameter in the `wp_json_encode()` function and associated functions to `$value`, and the `$options` parameter to `$flags` for parity with the parameter names used in PHP Core. Reference: [https://www.php.net/manual/en/function.json-encode.php PHP Manual: json_encode()]. Follow-up to [30055]. Props jrf, hellofromTonya. Fixes #59630. git-svn-id: https://develop.svn.wordpress.org/trunk@57130 602fd350-edb4-49c9-b593-d223f7449a82
…ncy. While “web site” was the original spelling, this variant has become rarely used, and “website” is now the standard spelling, already used throughout most of the WordPress core. Reference: [https://en.wikipedia.org/wiki/Website Wikipedia: Website]. Props LiamMcArthur, cafenoirdesign, sabbirshouvo, sabernhardt, ironprogrammer, mukesh27. Fixes #59853, #54276. git-svn-id: https://develop.svn.wordpress.org/trunk@57131 602fd350-edb4-49c9-b593-d223f7449a82
The MySQL project has introduced a new versioning strategy with two types of releases: innovation and long-term support. While long-term support is a familiar concept, it’s not clear how innovation releases should be supported in various WordPress versions for a number of reasons. Mainly, innovation releases are very short-lived. Each one is only supported until the next innovation version is released with a goal of one per quarter. Even though these versions will have a short lifespan they are described as producton-grade and generally available. More discussion is needed to determine exactly how each WordPress release should support these new innovation releases. But while the parameters for proper support are determined, the PHPUnit tests can be run against these innovation releases to detect any potential problems or incompatibilities. This change adds the `8.1` and `8.2` innovation releases to the testing matrix for the PHPUnit test worfklow. Props johnbillion, jorbin. See #59779. git-svn-id: https://develop.svn.wordpress.org/trunk@57132 602fd350-edb4-49c9-b593-d223f7449a82
…method is called. Follow-up to [34928]. Props xknown, joemcgill. Fixes #59601. git-svn-id: https://develop.svn.wordpress.org/trunk@57133 602fd350-edb4-49c9-b593-d223f7449a82
…PUnit tests. Follow-up to [45745], [47743]. Props pbearne, costdev. Fixes #59624. git-svn-id: https://develop.svn.wordpress.org/trunk@57134 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [54272], [56101]. Props rabmalin, Presskopp. Fixes #59563. git-svn-id: https://develop.svn.wordpress.org/trunk@57135 602fd350-edb4-49c9-b593-d223f7449a82
Adds translator comments where absent and changes code style so that comments are attached to the right strings during string extraction. Props NekoJonez. Fixes #59947 git-svn-id: https://develop.svn.wordpress.org/trunk@57136 602fd350-edb4-49c9-b593-d223f7449a82
This is a maintenance and feature release, adding support for the official release of PHP 8.3, methods for removing and replacing custom headers, XCLIENT support, and links to a new way of implementing XOAUTH2 authentication. The only change likely to have any impact on existing code is that PHPMailer previously attempted to use opportunistic STARTTLS encryption when connecting to `localhost`, which was unlikely to work. The workaround required setting `SMTPAutoTLS = false`, but that's no longer required. You may still need to use this setting when connecting to literal IPs. References: * [https://github.com/PHPMailer/PHPMailer/releases/tag/v6.9.1 PHPMailer 6.9.1 release notes] * [PHPMailer/PHPMailer@v6.8.1...v6.9.1 Full list of changes in PHPMailer 6.9.1] Follow-up to [50628], [50799], [51169], [51634], [51635], [52252], [52749], [52811], [53500], [53535], [53917], [54427], [54937], [55557], [56484]. Props jrf, Synchro. Fixes #59966. git-svn-id: https://develop.svn.wordpress.org/trunk@57137 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [49216], [49574]. Props sumisubedi, sabernhardt. Fixes #59495. git-svn-id: https://develop.svn.wordpress.org/trunk@57138 602fd350-edb4-49c9-b593-d223f7449a82
This aims to slightly improve performance by checking the faster `empty()` language construct first and potentially avoiding an unnecessary function call. Additionally, this better matches a similar conditional a few lines below. Follow-up to [17757], [17770]. Props Cybr. See #59650. git-svn-id: https://develop.svn.wordpress.org/trunk@57139 602fd350-edb4-49c9-b593-d223f7449a82
… registering a block type. This argument is an associative array of strings, not an array of arrays. See #59313, 59651 git-svn-id: https://develop.svn.wordpress.org/trunk@57140 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [44984], [56475]. Props upadalavipul, mukesh27. Fixes #59977. git-svn-id: https://develop.svn.wordpress.org/trunk@57141 602fd350-edb4-49c9-b593-d223f7449a82
…r message. When the `wp_login_errors` filter is used to add an error message followed by an instructional message, the former was not displayed and the latter was errouneously displayed twice above the login form. This commit ensures that the error message is displayed as expected. Follow-up to [56654]. Props mapumba. Fixes #59983. git-svn-id: https://develop.svn.wordpress.org/trunk@57142 602fd350-edb4-49c9-b593-d223f7449a82
Prevents pending upgrades from blocking tests when checking out previous builds. Props mukesh27. See #59647. git-svn-id: https://develop.svn.wordpress.org/trunk@57143 602fd350-edb4-49c9-b593-d223f7449a82
When JavaScript is disabled, the Add Plugins screen's search button position was too high in comparison to the search text field. This fix reuses the CSS declaration to keep field and button aligned. By targeting the `.no-js` class, the CSS specificity is not impacted when JavaScript is enabled. Follow up to [48281], [30830]. Props devmuhib, sabernhardt, huzaifaalmesbah, hellofromTonya. Fixes #59967. git-svn-id: https://develop.svn.wordpress.org/trunk@57144 602fd350-edb4-49c9-b593-d223f7449a82
Props pbearne. Fixes #59953. git-svn-id: https://develop.svn.wordpress.org/trunk@57145 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [55289]. Props shailu25. Fixes #60363. git-svn-id: https://develop.svn.wordpress.org/trunk@57371 602fd350-edb4-49c9-b593-d223f7449a82
…ed_block_markup()`. This aims to prevent type juggling causing incorrect results. Follow-up to [57157]. Props jrf. See #60279. git-svn-id: https://develop.svn.wordpress.org/trunk@57372 602fd350-edb4-49c9-b593-d223f7449a82
It is part of the sync from the Gutenberg plugin that introduces the registry for block binding sources required for the new Block Bindings API: WordPress/gutenberg#54536. See #60282. Props czapla, artemiosans, santosguillamot, sc0ttkclark, lgladdy, talldanwp, swissspidy, youknowriad, fabiankaegy. git-svn-id: https://develop.svn.wordpress.org/trunk@57373 602fd350-edb4-49c9-b593-d223f7449a82
…from two functions in WP_REST_Templates_Controller. This commit removes unnecessary access and internal annotations from two functions that are private and as such don't require the annotation. It also adds the since annotation with the 6.5 release given that the annotation may be useful. Props swissspidy. See #60358. git-svn-id: https://develop.svn.wordpress.org/trunk@57374 602fd350-edb4-49c9-b593-d223f7449a82
It is part of the sync from the Gutenberg plugin that introduces the registry for block binding sources required for the new Block Bindings API: WordPress/gutenberg#54536. See #60282. Follow-up [57373]. Props czapla, artemiosans, santosguillamot, sc0ttkclark, lgladdy, talldanwp, swissspidy, youknowriad, fabiankaegy, mukesh27. git-svn-id: https://develop.svn.wordpress.org/trunk@57375 602fd350-edb4-49c9-b593-d223f7449a82
This updates the `slackapi/slack-github-action` from `1.24.0` to `1.25.0`. This fixes more GitHub Action deprecated notices. Follow up to [57362]. See #59805. git-svn-id: https://develop.svn.wordpress.org/trunk@57376 602fd350-edb4-49c9-b593-d223f7449a82
This patch, somewhat small brings a lot to WordPress. This includes features like: - DataViews. - Customization tools like box shadow, background size and repeat. - UI improvements in the site editor. - Preferences sharing between the post and site editors. - Unified panels and editors between post and site editors. - Improved template mode in the post editor. - Iterations to multiple interactive blocks. - Preparing the blocks and UI for pattern overrides. - and a lot more. Props luisherranz, gziolo, isabel_brison, costdev, jonsurrell, peterwilsoncc, get_dave, antonvlasenko, desrosj. See #60315. git-svn-id: https://develop.svn.wordpress.org/trunk@57377 602fd350-edb4-49c9-b593-d223f7449a82
PHPCS has seen two new releases since the update to WPCS 3.0, with especially the 3.8.0 version containing a huge number of improvements. References: * [https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.8.0 PHP_CodeSniffer 3.8.0 release notes] * [https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.8.1 PHP_CodeSniffer 3.8.1 release notes] Follow-up to [56695]. Props jrf, swissspidy. Fixes #60279. git-svn-id: https://develop.svn.wordpress.org/trunk@57378 602fd350-edb4-49c9-b593-d223f7449a82
Version 8.3 is the latest short-term innovation release of MySQL. See #59779. git-svn-id: https://develop.svn.wordpress.org/trunk@57379 602fd350-edb4-49c9-b593-d223f7449a82
Props mukesh27, Dharm1025, Ankit K Gupta, swissspidy, dharm1025, tanjimtc71, timothyblynjacobs, spacedmonkey. Fixes #57897. git-svn-id: https://develop.svn.wordpress.org/trunk@57380 602fd350-edb4-49c9-b593-d223f7449a82
|
When I apply the patch on WordPress 6.5-alpha-56966 I am getting: And there are two blank lines at the end of the style-editor.scss file. Other than that, the PR solves the problem with the avatar radius. |
…cks. Props amieiro. See #59656. git-svn-id: https://develop.svn.wordpress.org/trunk@57381 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [57337] where this was already added for plugins. See #59656. git-svn-id: https://develop.svn.wordpress.org/trunk@57382 602fd350-edb4-49c9-b593-d223f7449a82
strpos was triggering a php warning. This also updates the code to use the now supported str_contains. Props get_dave, dmsnell, ocean90, mukesh27. Fixes #60327. git-svn-id: https://develop.svn.wordpress.org/trunk@57383 602fd350-edb4-49c9-b593-d223f7449a82
Previous Gutenberg versions are not compatible with recent trunk because of the WP_Navigation_Block_Renderer classname. It's present in both. Gutenberg has been updated to avoid the use of this class but we need to auto-disable old plugins to avoid fatals. Props hellofromtonya. See #60315. git-svn-id: https://develop.svn.wordpress.org/trunk@57384 602fd350-edb4-49c9-b593-d223f7449a82
Only block bindings sources registered in the tests should get unregistered. Follow-up for [57375]. See #60282. Props czapla. git-svn-id: https://develop.svn.wordpress.org/trunk@57385 602fd350-edb4-49c9-b593-d223f7449a82
Ensures that looking up a singular that is also used as a pluralized string works as expected. This improves compatibility for cases where for example both `__( 'Product' )` and `_n( 'Product', 'Products’, num )` are used in a project, where both will use the same translation for the singular version. Although such usage is not really recommended nor documented, it must continue to work in the new i18n library in order to maintain backward compatibility and maintain expected behavior. See #59656. git-svn-id: https://develop.svn.wordpress.org/trunk@57386 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [57386]. See #59656. git-svn-id: https://develop.svn.wordpress.org/trunk@57387 602fd350-edb4-49c9-b593-d223f7449a82
Props costdev, peterwilsoncc, azaozz, tykoted, johnbillion, desrosj, afragen, jorbin. git-svn-id: https://develop.svn.wordpress.org/trunk@57388 602fd350-edb4-49c9-b593-d223f7449a82
…erialize. Props xknown, peterwilsoncc, jorbin, desrosj. git-svn-id: https://develop.svn.wordpress.org/trunk@57389 602fd350-edb4-49c9-b593-d223f7449a82
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After Applying Patch Border radius issue will solved.
Trac ticket: 59285
Screenshots:
Before Patch: https://prnt.sc/AXe3wMAR7cr9
After Patch : https://prnt.sc/N74p7U-mj6Io
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.