Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unsetting of background image on mobile. #5534

Closed
wants to merge 1 commit into from

Conversation

aaronjorbin
Copy link
Member

Trac ticket: https://core.trac.wordpress.org/ticket/59289

On mobile, the background image is currently removed which causes dark text on a dark background. This was added in the design for 6.3.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

On mobile, the background image is currently remvoed which causes dark text on a dark background. This was added in the design for 6.3.

See: https://core.trac.wordpress.org/ticket/59289#comment:35
@sabernhardt
Copy link

I suggest replacing the current var(--background) with #EAE9E7, the light background color seen in the top right corner. That also could prevent problems if/when the image does not load.

The text overlap would be very common on screens below 600px, though it can overlap at others too. In right-to-left languages, the heading might always appear in front of the numbers.

Additionally, the 6.4 part of the image gets cut off at certain screen sizes.

the edge of the 4 is cut off at 968px:
English About page header at 968 pixels wide

text overlaps at 900px:
English About page header at 900 pixels wide

text would overlap at 414px if the background image is restored:
English About page header at 414 pixels wide

RTL text overlaps at 1200px:
Persian About page header at 1200 pixels wide

@lutzmex

This comment was marked as spam.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @lutzmex.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jorbin, sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@aaronjorbin
Copy link
Member Author

Forgot to close this months ago, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants