Only start main query loop when block template is associated with the current theme #5575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixarntz
requested review from
gziolo,
joemcgill,
hellofromtonya,
mukeshpanchal27 and
costdev
|
I have tested the PR and it fixes the issue. Thanks @felixarntz |
costdev
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Thanks for the quick work on this @felixarntz! I've left a few thoughts.
mukeshpanchal27
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Thank you, @felixarntz, for the quick PR. It looks solid to me.
costdev
approved these changes
Oct 26, 2023
afragen
suggested changes
Oct 27, 2023
|
Cross-sharing a test report from the ticket: WooCommerce Blocks had a related issue, which is fixed by this PR ✅ |
hellofromtonya
approved these changes
Oct 27, 2023
afragen
approved these changes
Oct 27, 2023
|
Committed in https://core.trac.wordpress.org/changeset/57019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally, the block template loaded should always be associated with the current theme since:
WP_Querythat filters to block templates only for theget_stylesheet()themeIn both cases, the template ID will begin with
get_stylesheet() . '//'.There are rare situations (e.g. the https://wordpress.org/plugins/echo-knowledge-base/ plugin as reported in the Trac ticket) where a plugin hijacks the block template loading mechanism to inject its own block template, which thus comes from outside the theme and may use any logic. In those cases, the situation is unpredictable by core and therefore the assumption that no main query loop will be present for a singular
WP_Queryis no longer reliable. As such, in those cases no main query loop should be started, as that would lead to problems if the custom logic was going to attempt to start the main query loop itself. So for those cases, the PR simply falls back to the original pre-6.4 logic of just parsing blocks.Trac ticket: https://core.trac.wordpress.org/ticket/59736
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.