HTML API: Trigger active format reconstruction when reaching text nodes. #6054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
dmsnell
commented
Feb 7, 2024
sirreal
reviewed
Feb 7, 2024
|
I expected this to fix some of the tests from #5794 but this seems to have no impact at all on the html5lib tests results. |
sirreal
approved these changes
Feb 7, 2024
westonruter
reviewed
Feb 7, 2024
dmsnell
force-pushed
the
html-api/reconstruct-active-formatting-elements-on-text
branch
from
6ea811d
to
3050b34
Compare
|
@westonruter would you mind giving this another pass? I added tests to assert the behavior, and they fail in |
sirreal
approved these changes
Feb 27, 2024
tests/phpunit/tests/html-api/wpHtmlSupportRequiredActiveFormatReconstruction.php
Outdated
Show resolved
Hide resolved
westonruter
reviewed
Feb 27, 2024
tests/phpunit/tests/html-api/wpHtmlSupportRequiredActiveFormatReconstruction.php
Outdated
Show resolved
Hide resolved
westonruter
reviewed
Feb 27, 2024
dmsnell
force-pushed
the
html-api/reconstruct-active-formatting-elements-on-text
branch
2 times, most recently
from
e9bbdbf
to
c57f20f
Compare
|
I'm not sure what is happening, because I thought this was all green, but it wasn't testing properly for me, and upon deeper inspection, I think many things need updating. In fdb23e7 I have made the tests pass, but I'm concerned this is too rushed and that we should try a different approach, namely, detecting if we need reconstruction and bailing on a text node if we do. |
dmsnell
force-pushed
the
html-api/reconstruct-active-formatting-elements-on-text
branch
from
96975a2
to
fdb23e7
Compare
dmsnell
force-pushed
the
html-api/reconstruct-active-formatting-elements-on-text
branch
from
fdb23e7
to
39f6ae2
Compare
When encountering text nodes in an HTML document, the HTML parser needs to run the active format reconstruction algorithm, even if it doesn't stop to visit those text nodes. This is because the formats, which might need reconstructing, will impact the breadcrumbs of all downstream nodes from the text node. In this patch, this process is triggered, but the text nodes are then skipped, since the HTML Processor doesn't currently support visiting them. Co-authored-by: Weston Ruter <westonruter@git.wordpress.org> Co-authored-by: Jon Surrell <jonsurrell@git.wordpress.org>
dmsnell
force-pushed
the
html-api/reconstruct-active-formatting-elements-on-text
branch
from
4e697fc
to
d8c1078
Compare
pento
pushed a commit
that referenced
this pull request
Mar 12, 2024
When encountering text nodes in an HTML document, the HTML parser needs to run the active format reconstruction algorithm, even if it doesn't stop to visit those text nodes. This is because the formats, which might need reconstructing, will impact the breadcrumbs of all downstream nodes from the text node. In this patch, this process is triggered, which properly triggers the active format reconstruction. It also enables the visiting of other token types as is possible in the Tag Processor. Developed in #6054 Discussed in https://core.trac.wordpress.org/ticket/60170 Props: dmsnell, jonsurrell, westonruter. Fixes: #60455. Follow-up to: [57348]. git-svn-id: https://develop.svn.wordpress.org/trunk@57806 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Mar 12, 2024
When encountering text nodes in an HTML document, the HTML parser needs to run the active format reconstruction algorithm, even if it doesn't stop to visit those text nodes. This is because the formats, which might need reconstructing, will impact the breadcrumbs of all downstream nodes from the text node. In this patch, this process is triggered, which properly triggers the active format reconstruction. It also enables the visiting of other token types as is possible in the Tag Processor. Developed in WordPress/wordpress-develop#6054 Discussed in https://core.trac.wordpress.org/ticket/60170 Props: dmsnell, jonsurrell, westonruter. Fixes: #60455. Follow-up to: [57348]. Built from https://develop.svn.wordpress.org/trunk@57806 git-svn-id: http://core.svn.wordpress.org/trunk@57307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
dmsnell
deleted the
html-api/reconstruct-active-formatting-elements-on-text
branch
github-actions bot
pushed a commit
to gilzow/wordpress-performance
that referenced
this pull request
Mar 12, 2024
When encountering text nodes in an HTML document, the HTML parser needs to run the active format reconstruction algorithm, even if it doesn't stop to visit those text nodes. This is because the formats, which might need reconstructing, will impact the breadcrumbs of all downstream nodes from the text node. In this patch, this process is triggered, which properly triggers the active format reconstruction. It also enables the visiting of other token types as is possible in the Tag Processor. Developed in WordPress/wordpress-develop#6054 Discussed in https://core.trac.wordpress.org/ticket/60170 Props: dmsnell, jonsurrell, westonruter. Fixes: #60455. Follow-up to: [57348]. Built from https://develop.svn.wordpress.org/trunk@57806 git-svn-id: https://core.svn.wordpress.org/trunk@57307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento
pushed a commit
that referenced
this pull request
Mar 13, 2024
When encountering text nodes in an HTML document, the HTML parser needs to run the active format reconstruction algorithm, even if it doesn't stop to visit those text nodes. This is because the formats, which might need reconstructing, will impact the breadcrumbs of all downstream nodes from the text node. In this patch, this process is triggered, which properly triggers the active format reconstruction. It also enables the visiting of other token types as is possible in the Tag Processor. Developed in #6054 Discussed in https://core.trac.wordpress.org/ticket/60170 Reviewed by swissspidy. Merges [57806] to the to the 6.5 branch. Props: dmsnell, jonsurrell, westonruter. Fixes: #60455. Follow-up to: [57348]. git-svn-id: https://develop.svn.wordpress.org/branches/6.5@57823 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Mar 13, 2024
When encountering text nodes in an HTML document, the HTML parser needs to run the active format reconstruction algorithm, even if it doesn't stop to visit those text nodes. This is because the formats, which might need reconstructing, will impact the breadcrumbs of all downstream nodes from the text node. In this patch, this process is triggered, which properly triggers the active format reconstruction. It also enables the visiting of other token types as is possible in the Tag Processor. Developed in WordPress/wordpress-develop#6054 Discussed in https://core.trac.wordpress.org/ticket/60170 Reviewed by swissspidy. Merges [57806] to the to the 6.5 branch. Props: dmsnell, jonsurrell, westonruter. Fixes: #60455. Follow-up to: [57348]. Built from https://develop.svn.wordpress.org/branches/6.5@57823 git-svn-id: http://core.svn.wordpress.org/branches/6.5@57324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: Core-60455
See alternative in #6203See alternative in sirreal#6
Status
Description
When encountering text nodes in an HTML document, the HTML Parser needs to run the active format reconstruction algorithm, even if it doesn't stop to visit those text nodes. This is because the formats, which might need reconstructing, will impact the breadcrumbs of all downstream nodes from the text node.
In this patch, this process is triggered, but the text nodes are then skipped, since the HTML Processor doesn't currently support visiting them.