-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve site icon but don't change the UI #6165
Improve site icon but don't change the UI #6165
Conversation
…$. Wrap feature in a function
…et/wordpress-develop into 54370-site-icon-post-review
…4370-site-icon-post-review
…review in the cropper
…4370-site-icon-post-review
npx prettier@npm:wp-prettier@latest --write src/js/_enqueues/admin/site-icon.js npx prettier@npm:wp-prettier@latest --write src/wp-admin/css/site-icon.css
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
…4370-site-icon-post-review-old-ui
…jorbin/wordpress-develop into 54370-site-icon-post-review-old-ui
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
switchToUpdate( attachment ); | ||
frame.close(); | ||
|
||
// Start over with a frame that is so fresh and so clean clean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment was flagged as odd, and I agree. Is this an Outkast reference or something?
This is a copy of #6109 but with the existing UI rather than a new one.
https://core.trac.wordpress.org/ticket/54370