-
Notifications
You must be signed in to change notification settings - Fork 220
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PHP.wasm: yield 0 bytes read on fd_read failure to improve PHP's frea…
…d() and feof() behavior (#1053) Ensures that PHP.wasm indicates that `feof($fp) === true` when reading from pipes exposed by `proc_open()` after the process have exited and all the data have been read. [Internally in stdiop_read](https://github.com/php/php-src/blob/718a8b4278cf811919906045d3bea4092e8a0844/main/streams/plain_wrapper.c#L426-L453), PHP expects the read() syscall to return 0 while indicating that the number of bytes read was also 0. This PR makes the PHP.wasm polling logic comply with those expectations. ## Remaining work Rebuild all the PHP versions. ## Testing instructions Confirm the CI checks for PHP 8.2 are green.
- Loading branch information
Showing
56 changed files
with
696 additions
and
460 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.