PHP.wasm: yield 0 bytes read on fd_read failure to improve PHP's fread() and feof() behavior #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that PHP.wasm indicates that `feof($fp) === true` when reading from pipes exposed by `proc_open()` after the process have exited and all the data have been read. Internally in stdiop_read, PHP expects the read() syscall to return 0 while indicating that the number of bytes read was also 0: https://github.com/php/php-src/blob/718a8b4278cf811919906045d3bea4092e8a0844/main/streams/plain_wrapper.c#L426-L453 This PR makes the PHP.wasm polling logic comply with those expectations. ## Remaining work Rebuild all the PHP versions. ## Testing instructions Confirm the CI checks are green.
adamziel
changed the title
adamziel
deleted the
php-wasm-fix-feof-and-fread-from-finished-process
branch
adamziel
commented
Feb 26, 2024
| var returnCode; | ||
| var stream; | ||
| let num = 0; | ||
| try { |
There was a problem hiding this comment.
Oh no, I've mixed tabs and spaces!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that PHP.wasm indicates that
feof($fp) === truewhen reading from pipes exposed byproc_open()after the process have exited and all the data have been read.Internally in stdiop_read, PHP expects the read() syscall to return 0 while indicating that the number of bytes read was also 0. This PR makes the PHP.wasm polling logic comply with those expectations.
Testing instructions
Confirm the CI checks are green.