New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP: artifact_not_found error #1260
Comments
@Rcreators I tried testing your PR in Playground but it's stuck on _Waiting for GitHub to finish building PR 6238. _. I assume this is because the PR failed some build steps. |
@bgrgicak that's exactly what this issue is about :-) if you trace the execution, the plugin proxy endpoint errros out with artifact_not_found |
@bgrgicak If you check the PR, it actually Passed all the checks before but it still had issue. I just refreshed the code to get it build again if that solve but nothing happened. Also the falling parameter is due to time out or something unrelated to code itself. |
Thanks! I just saw the UI failing and thought it was unrelated. I'm taking a look at the issue now. |
This is caused by the name in the artifact response not matching the artifact name. I'm trying to understand now why and how can we fix it. |
I checked the list of names the API returns and the requested name isn't there:
|
It ensures that the WordPress pull request test page can fetch the correct PR data. Fixes #1260 ## What problem is it solving? When a branch name has special characters like _#_, GitHub API requests may not work as intended. ## How is the problem addressed? By encoding the branch name. ## Testing Instructions - Checkout this branch - Start a local PHP server ``` cd packages/playground/website/public docker run -d -p 8787:80 -v "$PWD":/var/www/html php:8.0-apache ``` - Add the localhost path (`http://localhost:8787`) to the [start of this url](https://github.com/WordPress/wordpress-playground/blob/9f134e046102a1d2858b0b0541abfa9182b64291/packages/playground/website/public/wordpress.html#L147) - Replace this [line with a valid token](https://github.com/WordPress/wordpress-playground/blob/ac62f0c170d89ea0127900eeb628062db74cd2c9/packages/playground/website/public/plugin-proxy.php#L264) (from the server) - [Open this URL](http://localhost:5400/website-server/wordpress.html?pr=6238) - Ensure Playground is loaded
@bgrgicak I am not sure if this is solved. I just tried to test the PR in playground and it still take me to waiting message. Tried few times and waited for 5 mins. Not working. Will it take time to reflect on actual playground? |
@Rcreators the website isn't automatically deployed after merging a Pull Request, I just started the deploy job. It should be good in 15 mins |
WordPress/wordpress-develop#6238
The above particular PR is not working on the playground. Its just showing waiting time for loading the PR.
As per Slack discussion in the #accessibility channel, @adamziel mentioned that it has something to do with this particular line and to submit a issue here.
wordpress-playground/packages/playground/website/public/plugin-proxy.php
Line 66 in 98972d8
Someone please look into it and let me know how to solve it or someway around to run that PR in playground.
The text was updated successfully, but these errors were encountered: